Apps-android-commons: Clearing recent searches only removes last 10

Created on 20 Dec 2018  路  2Comments  路  Source: commons-app/apps-android-commons

Summary:

Currently, clicking the 'bin' icon on searches only deletes your last 10 searches. Personally I think it should wipe your entire search history - I'm not sure why it's implemented the way it is currently.

If however we do want it to only delete last 10 then at least the method call should be renamed to something other than deleteAll

https://github.com/commons-app/apps-android-commons/blob/b0b4b0810084a89d2be80c10814be921ecaa4835/app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java#L58

assigned bug
Source
picture domdomegg
👍1

Most helpful comment

Hey.I had started working on this

picture cypherop on 20 Dec 2018
👍2

All 2 comments

I agree that it should delete the entire search history

maskaravivek picture maskaravivek on 20 Dec 2018

Hey.I had started working on this

cypherop picture cypherop on 20 Dec 2018
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

psh picture psh  路  3Comments
Opsylac picture Opsylac  路  3Comments
neslihanturan picture neslihanturan  路  3Comments
domdomegg picture domdomegg  路  3Comments
misaochan picture misaochan  路  4Comments