Apps-android-commons: No alpha APKs despite master commits

[nicolas-raoul]

There have been 6 commits to master today, yet no alpha APK has made it to Google Play:

(Now almost midnight here)

[domdomegg]

I did update the way Travis builds stuff in https://github.com/commons-app/apps-android-commons/commit/e6593c55e9114f76203d2a5498a724a73938ebe8, could be related?

Can you tell what commit version 113 was?

[domdomegg]

Doing a bit of testing in the app, I think it was my change in #2162 that broke it (sorry). Reason I think this is because the alpha from Google Play has plural string support (db38174eb4129316ff801ce89e4b8298e0495a77) but the category lists are still broken (46db38b8e902b4f81333ea54de41f861407c0e3c), and there's only two commits between there.

[maskaravivek]

@domdomegg Have you figured out a fix or should I try making a change?

You could directly commit to master for attempting the fix.

[domdomegg]

Think it's a bash whitespace problem, going to check Travis logs to see if it confirms my suspicions if so I'll try push a fix. Otherwise will revert commit.

[maskaravivek]

@nicolas-raoul 6 more commits are soon going to be added to master. #2174.

Hopefully, @domdomegg's change will fix alpha publishing then there would be a lot of new fixes on the master. :)

[domdomegg]

Travis now failing but not quite sure why my change is making it fail. Going to retry build in case it was just a coincidence.

From https://api.travis-ci.org/v3/job/470100834/log.txt

Starting 2 tests on test(AVD) - 5.1.1

fr.free.nrw.commons.SettingsActivityTest > oneLicenseIsChecked[test(AVD) - 5.1.1] FAILED 
    java.lang.RuntimeException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:

    Root{application-window-token=android.view.ViewRootImpl$W@3ab36fd4, window-token=android.view.ViewRootImpl$W@3ab36fd4, has-window-focus=false, layout-params-type=1, layout-params-string=WM.LayoutParams{(0,0)(fillxfill) sim=#100 ty=1 fl=#81810100 wanim=0x1030466 surfaceInsets=Rect(0, 0 - 0, 0) needsMenuKey=2}, decor-view-string=DecorView{id=-1, visibility=VISIBLE, width=480, height=800, has-focus=true, has-focusable=true, has-window-focus=false, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params=WM.LayoutParams{(0,0)(fillxfill) sim=#100 ty=1 fl=#81810100 wanim=0x1030466 surfaceInsets=Rect(0, 0 - 0, 0) needsMenuKey=2}, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}}


fr.free.nrw.commons.SettingsActivityTest > afterClickingCcby4ItWillStay[test(AVD) - 5.1.1] FAILED 
    java.lang.RuntimeException: Waited for the root of the view hierarchy to have window focus and not request layout for 10 seconds. If you specified a non default root matcher, it may be picking a root that never takes focus. Root:

    Root{application-window-token=android.view.ViewRootImpl$W@114e1dde, window-token=android.view.ViewRootImpl$W@114e1dde, has-window-focus=false, layout-params-type=1, layout-params-string=WM.LayoutParams{(0,0)(fillxfill) sim=#100 ty=1 fl=#81810100 wanim=0x1030466 surfaceInsets=Rect(0, 0 - 0, 0) needsMenuKey=2}, decor-view-string=DecorView{id=-1, visibility=VISIBLE, width=480, height=800, has-focus=true, has-focusable=true, has-window-focus=false, is-clickable=false, is-enabled=true, is-focused=false, is-focusable=false, is-layout-requested=false, is-selected=false, layout-params=WM.LayoutParams{(0,0)(fillxfill) sim=#100 ty=1 fl=#81810100 wanim=0x1030466 surfaceInsets=Rect(0, 0 - 0, 0) needsMenuKey=2}, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, child-count=2}}

:app:connectedBetaDebugAndroidTest FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:connectedBetaDebugAndroidTest'.
> There were failing tests. See the report at: file:///home/travis/build/commons-app/apps-android-commons/app/build/reports/androidTests/connected/flavors/BETA/index.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 15m 57s

EDIT - the more I look into it, the more I think it was just coincidence. Travis re-running now, will monitor carefully to see if same issue reoccurs.

[maskaravivek]

@domdomegg Have canceled 2 master builds(one of it was yours) and now the latest master is building. If that works, your change would also get validated.

[domdomegg]

Yay, Travis is successful now. Was just freak coincidence I guess ¯\_(ツ)_/¯

[domdomegg]

@nicolas-raoul can you check there are now new releases in Google Play?

[nicolas-raoul]

@domdomegg Yes it is working thanks :-)