Apps-android-commons: App bar scrolls when it shouldn't

[domdomegg]

Summary:

The toolbar scrolls when really it should be the contents of certain activities that scroll only. See GIF below demonstrating behaviour.

Most likely you will need to change files in /res/layout/

Places where this happens

• Achievements
• About
• other places I've forgotten to check?

Comment if you are working on this issue beforehand so we don't have two people working on the same thing. Feel free to submit one pull request that contains all changes, or many small ones. If it turns out to be kinda complex, go down the many small ones route. Do tag me (@domdomegg) if you need a review.

Steps to reproduce:

Open "About" activity and scroll up and down

Screen-shots:

| Actual | Expected (toolbar stays fixed) |
| - | - |
| | |

[vanshikaarora]

I am wiling to work on this error. Before that can you please elaborate on what phone you got this issue. Because I tried to do the same on my phone and i couldn't come across any error.

[neslihanturan]

Thanks @vanshikaarora , the issue is toolbar is also moving with page content. Ideally it should stay and content should scroll.

[vanshikaarora]

Sir i got what you have posted but in my case. For about actitvity neither the toolbar nor the activity is scrolled.

[domdomegg]

It's likely that your phone has a higher dp resolution so you can see the whole page without scrolling. Maybe try an emulator with a lower resolution or bumping up the display scaling on your phone?

[vanshikaarora]

OK sir I'll check this out on an emulator and then start working upon this.

[neslihanturan]

Thanks @vanshikaarora , and our team has a motto: No sirs here, just friends:)

[vanshikaarora]

Sorry to say that @neslihanturan. And thanks for that courtesy :)

[vanshikaarora]

Hey I am working upon this issue

[neslihanturan]

Thanks @vanshikaarora , did you managed to reproduce the issue?

[vanshikaarora]

No, I couldn't. I tried on an emulator but my system cannot suffered frequent non responsive states due to gradle build of the heavy project as well as the emulator.

But yet i went through the xml file for these activities and i could get what was wrong with the code that generated this issue.

[neslihanturan]

Oh okay, if you have a theory go for it. But what about finishing your open PR first? It is always better working on one PR at at time.

[vanshikaarora]

Yes I completely inderstand my first priority is the previous PR also i had
staerted to think upon this PR.

On Thu, Dec 20, 2018 at 7:51 PM neslihanturan [e-mail]
wrote:

Oh okay, if you have a theory go for it. But what about finishing your
open PR first? It is always better working on one PR at at time.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/2165#issuecomment-449014605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgrLuSVk6cVKdxRkY-ozd77sl9tsUBViks5u65z2gaJpZM4ZZQEq
.

[vanshikaarora]

@neslihanturan Now I'll start working upon this