Apps-android-commons: When uploading multiple images the image license selector implies singular

[domdomegg]

Summary:

When uploading multiple images and selecting a license you get a message like:

"This image will be licensed under "
but it should be
"These images will be licensed under "

Screen-shots:

[ravi-kishan]

Hello, I've started working on this.

[zhao-gang]

@ravi-kishan @domdomegg

Hi, I am also working on this. I use the plurals string way (https://developer.android.com/guide/topics/resources/string-resource#Plurals). I think that'd be good for i18n.

Will send a PR soon.

[neslihanturan]

Hi @zhao-gang and @ravi-kishan , if one of you is just starting and the other has some progress, I suggest the one who just started can pick another issue, two prevent both of you work on same task.

Did you both already made some progress?

[zhao-gang]

@neslihanturan I have made it working by using plurals string. But need some clean up to submit a PR.

[neslihanturan]

@ravi-kishan might be working for two hours also, it is always better to comment before you start. Lets wait for @ravi-kishan 's answer. If he is also close to finalize PR, I would let him send PR and pick another task. But if he is just started, then he can let you to send PR. We need some communication here:) Thanks both of you for your previous and current contributions and help though:)

[zhao-gang]

@neslihanturan I see @ravi-kishan has already sent a PR ( #2159 ). His approach is not the same as mine. And I think my solution might be better than his. Let's see :-)

[ravi-kishan]

The PR(#2159 ) is final from me.

[ravi-kishan]

As @zhao-gang has pointed out that he has a better way of implementing it, I think he should also send the PR and the better one will be merged.

[neslihanturan]

@zhao-gang , maybe it can be better to adding your reviews under already ready PR of @ravi-kishan , instead of sending another PR . By this way, he can either improve his solution or leave it as is. Since we are all cooperating here. Having two different PR for same task puts reviewer in a hard situation though.

[neslihanturan]

Well, so if you are okay with this @ravi-kishan , waiting for your PR @zhao-gang . Thanks both:)

[zhao-gang]

@ravi-kishan @domdomegg @neslihanturan Hi all, I have submitted my PR. I was not familiar with this project's development process so I didn't comment on this issue before working on it. Sorry for the inconvenience.