Apps-android-commons: Allow dynamic loading of contributions, without number limit

Created on 10 Nov 2018  路  7Comments  路  Source: commons-app/apps-android-commons

There was a request on our mailing list:

Hello
It would be great if we can show images up to 1000 or more.
Thank you
Tris T7

While there are bandwidth and memory concerns with downloading large numbers of images, I personally think if the user decides they want to, we should allow it (however the default should remain the same as currently). Currently the max you can set in Settings is 500. Would this be a good idea?

IEG

All 7 comments

I think the ideal solution would be to implement My Uploads like it is done in Explore:

  1. Load N images
  2. When the scrolling user comes close to the end of these N, load N more. Etc.

Agreed. Will change the title accordingly.

I would like to pick this up.

@maskaravivek Don't hesitate to use the "Assignees" button to assign issues to yourself :-)

The code in contributions fragment and contribution list fragment is quite old and things have been patched on top of it. One of the focus areas of the next grant is to overhaul legacy code(#1092) and introduce a consistent code pattern across the app.

So, before starting working on this talk it would be great if we could finalize the architecture for the presentation layer. Let's continue the discussion for the architecture in #888.

@ashishkumar468 Recently you refactored the contributions list. Can you confirm if this has already been taken care of?

@maskaravivek my refactors did not change the way things were already there. AFAIK I know such things would need pagination at the end of the recycler view which is not there as of now

Was this page helpful?
0 / 5 - 0 ratings