Apps-android-commons: No source text for Commons-android-strings-welcome_help_button_text (commons-android-strings)

[Nikerabbit]

Summary:

I am seeing this in our logs:
No source text for Commons-android-strings-welcome_help_button_text (commons-android-strings)

It's probably the previously encountered issue about HTML tags present. Could you apply the usual fix?

[Nikerabbit]

Also noticed another one now: Commons-android-strings-nominated_see_more

[Mansi449]

@Nikerabbit can you please elaborate upon the issue and also give some insights on how to resolve it?

[Nikerabbit]

1258 has more details.

[Mansi449]

Okay! Thanks! I got that.
Just wanted to know at what point does No source text for Commons-android-strings-welcome_help_button_text (commons-android-strings) get logged?

[Nikerabbit]

It's a sanity check I've put in our (translatewiki.net) code to catch issues like this.

[misaochan]

This looks to be similar to #1333 . I will copy my suggestion here:

So, what needs to be done in this task is:

1. go to strings.xml and search for all strings that have a <u> tag added but no CDATA tag
2. add the CDATA tag to those strings

[misaochan]

Note to collaborators @maskaravivek @neslihanturan @nicolas-raoul - In the future when we merge PRs, we should check that the strings added do not have HTML tags without CDATA.

[Mansi449]

Thanks @Nikerabbit @misaochan for the clarification.
I would like to work on this issue.

[misaochan]

@Mansi449 wonderful! However, it seems that both you and @arshadkazmi42 have expressed interest simultaneously in working on this in separate issues, so I am not sure who to assign it to. Could you both please discuss among yourselves and hopefully come to an agreement? :) Thanks!

[arshadkazmi42]

@Mansi449 if you have started working on this you can take this up. If you would like me to work on it, let me know.

[Mansi449]

Thanks a lot @arshadkazmi42 for letting me take this up.

[misaochan]

Thanks guys! @Mansi449 it is yours. :)

[Mansi449]

I added the CDATA tag to a string:
<string name="welcome_help_button_text"><![CDATA[<u>More Information</u>]]></string>
But it gives the following result:

I think something like this has to be done:
TextView tv = findViewById(R.id.welcomeInfo); (welcomeInfo is the TextView that contains the string "More Information").
Then:
tv.setText(Html.fromHtml(String.valueOf(R.string.welcome_help_button_text)));

@Nikerabbit @misaochan What do you think?

[maskaravivek]

Yes, you are right. You need to use:

tv.setText(Html.fromHtml(String.valueOf(R.string.welcome_help_button_text)));

[Mansi449]

Thanks @maskaravivek I would make the necessary changes.

[Mansi449]

@Nikerabbit @maskaravivek @misaochan I have made the required changes for the welcome_help_button_text string.
But another string <string name="nominated_see_more"><u>See webpage for details</u></string> has the same issue.
So shall I create a PR for this issue now and fix the nominated_see_more string in a separate issue or shall I create the PR only after fixing the nominated_see_more string also?

[maskaravivek]

IMO it should be fine to fix both the strings in a single PR. You can name the PR accordingly.

[Mansi449]

Ok sure, thanks!