Apps-android-commons: Add Share app option inside app

Created on 11 Mar 2018 · 21Comments · Source: commons-app/apps-android-commons

Summary:

There should be an option to share the app.

Steps to reproduce:

Add option to share in navigation drawer.
On Click of share option -

Intent sendIntent = new Intent();
sendIntent.setAction(Intent.ACTION_SEND);
sendIntent.putExtra(Intent.EXTRA_TEXT, "sharetext");
sendIntent.setType("text/plain");
startActivity(Intent.createChooser(sendIntent, getString(R.string.share)));

Expected behavior:
There should be an option to share the app.

Observed behavior:
There is no option to share the app.

Commons app version:
2.6.7

assigned enhancement good first issue

Source

ujjwalagrawal17

Most helpful comment

Keeping the share button in the top bar (Toolbar) of the About page also seems to be a good idea to me. That way it won't get lost in the already overcrowded About page.

maskaravivek on 14 Mar 2018

👍2

All 21 comments

Share text can be
Upload photos to Wikimedia Commons using the app.
Download Now: Google play link

I need some suggestions for the text

ujjwalagrawal17 on 11 Mar 2018

This enhancement looks good to me. Let's wait for others to pitch in before starting work on it. :)

maskaravivek on 12 Mar 2018

Looks good to me, but I would probably put this in About instead of the nav drawer. Nav drawer is getting quite full. ;) I also think the text should be:

Upload photos to Wikimedia Commons on your phone
Download the Commons app: Google play link

misaochan on 12 Mar 2018

👍1

Could you please post screenshots of a few popular apps that have a similar feature? Thanks!

nicolas-raoul on 12 Mar 2018

![screenshot_20180312-225425](https://user-images.githubusercontent.com/19607555/37312801-83c747c2-2672-11e8-9055-6e5b3d77bf0c.png)

![screenshot_20180313-040737](https://user-images.githubusercontent.com/19607555/37313183-14cfe0ac-2674-11e8-915a-cee67dd47489.png)

Screenshots from Phimp.me

ujjwalagrawal17 on 12 Mar 2018

I have worked on this issue can I submit PR?

aniket1897 on 13 Mar 2018

@aniket1897 I wanted to work on it. You should ask before working on the issue.
But since you had already worked on it. You submit the PR.

ujjwalagrawal17 on 13 Mar 2018

Sorry @ujjwalagrawal17 new to open source , next time I will take care.

aniket1897 on 13 Mar 2018

@nicolas-raoul @misaochan Your opinions on whether we need this feature? :)

maskaravivek on 13 Mar 2018

I definitely think it should NOT be in the navigation drawer the way the app in the screenshot does it. Feels a lot like feature bloat and users might get annoyed, since it isn't really something they would use often.

However, I think it could be nice to have a little "Share" icon in About. Perhaps next to the FB etc icons?

misaochan on 14 Mar 2018

👍1

Keeping the share button in the top bar (Toolbar) of the About page also seems to be a good idea to me. That way it won't get lost in the already overcrowded About page.

maskaravivek on 14 Mar 2018

👍2

@maskaravivek Sounds like a plan! 👍

misaochan on 15 Mar 2018

@maskaravivek I start working on this

wailbabou on 18 Mar 2018

@wailbabou we already have a PR on this issue by @aniket1897

ujjwalagrawal17 on 18 Mar 2018

@ujjwalagrawal17 but there is no comments from him since 5 days ! , and you said :[ If it takes more than two days, please post other comments at least every two days]

wailbabou on 18 Mar 2018

Hi @ujjwalagrawal17, I would like to work on this issue.
I would add the share icon at the top bar of the About page, in accordance with the idea proposed by @maskaravivek