Apps-android-commons: Show complete text of welcome notification

Created on 27 Feb 2018  路  8Comments  路  Source: commons-app/apps-android-commons

Summary:
Welcome Notification doesn't redirect the user to any link. As a user, I would like to know the complete information displayed in the notification. So, Either it should redirect the user to an external link containing the full information or it should show the complete text of the notification.

Steps to reproduce:

  1. After Login, click on Notifications.
  2. Check the welcome notification.

Device and Android version:
Samsung A8
Android 6.0 Marshmallow

Commons app version:
2.6.7

Screen-shots:
2

How will I proceed on this issue
Since the API itself doesn't provide any link for welcome notifications. Removing the maxLines limit of title can be a quick fix. @maskaravivek please let me know if this approach is okay, will open the PR accordingly.
Thanks. :)

Most helpful comment

Can't we include a button in notification to completely see the notification, so whenever a user clicks on that notification button complete text will be displayed something like see more, see fewer buttons in LinkedIn, Facebook.
Example:
bug

All 8 comments

Am not sure how the notifications would look if the message is too long. Instead of removing the maxLines limit we can probably just increase it.
Moreover:

  • It would be great if we could reduce the padding and size of the image. That would give us some more space for the notification text.

Can't we include a button in notification to completely see the notification, so whenever a user clicks on that notification button complete text will be displayed something like see more, see fewer buttons in LinkedIn, Facebook.
Example:
bug

The see more option actually makes sense and it would be great if we could implement that.

I would like to work on this issue

Sure, please feel free to pick this up. :)

@maskaravivek I have created a fix. Please review it, I will create a pull request accordingly. Thanks :)
Screenshot showing what changed.
solved3

@Jatin0312 I couldn't find the PR for this. Can you attach a link for it.

Ya sure, I will send a PR soon.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Opsylac picture Opsylac  路  3Comments

neslihanturan picture neslihanturan  路  3Comments

psh picture psh  路  3Comments

nicolas-raoul picture nicolas-raoul  路  4Comments

psh picture psh  路  4Comments