Apps-android-commons: Change toolbar color to primary color

Created on 24 Feb 2018  路  8Comments  路  Source: commons-app/apps-android-commons

Summary:

According to guidelines by Google
Toolbar background color should be the primary color.
Statusbar background color should be primary Dark color.

Steps to reproduce:

Change toolbar background to primary color in toolbar.xml

Expected behavior:

Toolbar background color should be the primary color.

Observed behavior:

Toolbar background color is primary dark color.

Screen-shots:

![screenshot_20180224-180318](https://user-images.githubusercontent.com/19607555/36630519-7a6143c8-198d-11e8-939f-02def108be12.png) ![screenshot_20180224-180552](https://user-images.githubusercontent.com/19607555/36630522-872a86a0-198d-11e8-8b6d-9d4efde2d09a.png)

Image 1->Before

Image 2->After

Most helpful comment

Dropping our primary / dark blue colors into Google's material design Color Tool shows how the colors should be used visually.

01 02 03

04 05 06

All 8 comments

Sounds good! @ujjwalagrawal17 can you include a link to Google's guideline for reference. :)

It's the correct way to use colorPrimaryDark on status bar and colorPrimary on toolbar as suggested by @ujjwalagrawal17

@maskaravivek you can find it in Google's Android studio developer manual here



#3F51B5

<!--   a darker variant of the primary color, used for
       the status bar (on Android 5.0+) and contextual app bars -->
<color name="colorPrimaryDark">#303F9F</color>

<!--   a secondary color for controls like checkboxes and text fields -->
<color name="colorAccent">#FF4081</color>

Dropping our primary / dark blue colors into Google's material design Color Tool shows how the colors should be used visually.

01 02 03

04 05 06

Can we change the primary/primary dark color to any one of these?






I had attached 2 combinations

Image 1 has our Primary color and Primary Dark color 2 shades darker than primary color
Image 2 has our Primark Dark color and primary color 2 shades lighter than primary dark color

Shades are selected from https://coolors.co/0c609c-0a4f80-2e5b87-00376d-685044

I want feedback from you so that we can change any one color.

@nicolas-raoul @maskaravivek what do you think?

Pinging @neslihanturan , as the current color scheme was created by her.

If I had to choose between Image 1 and Image 2 in your comment two days ago, I guess I would choose Image 2 :-)

Should I close this issue?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

maskaravivek picture maskaravivek  路  3Comments

nicolas-raoul picture nicolas-raoul  路  4Comments

psh picture psh  路  3Comments

domdomegg picture domdomegg  路  3Comments

misaochan picture misaochan  路  4Comments

screenshot_20180228-010941

screenshot_20180228-010819