Apps-android-commons: Revamp the Settings page

[sivaraam]

• [ ] Categorize the items so that user is able to get what he wants quickly. Possible categories for the currently available content are Appearance, General, Feedback
• [ ] Clarify why disabling "Use Wikidata" would cause huge data consumption. This could be done possibly by using a 'Learn more' link to a page that explains the reason.
• [ ] The heading 'License' isn't clear enough. 'Default license' would possibly be better
• [ ] Use toggle buttons instead of checkboxes as toggle buttons are more suitable for two state settings like "Night mode".

It would be nice if the material design guidelines for Settings was considered while doing this. I find their suggestion to be one that aims for an intuitive interface.

[misaochan]

Agreed completely with the revamp, especially with using material design guidelines and categorization of items.

[afswift]

If this issue isn't being worked on currently, I would love to tackle this issue. I've been working with android studio for a few months now.

If this is needed for parsing through:

I start working on this

[maskaravivek]

@afswift Feel free to work on it. :)

[misaochan]

@afswift Go for it. :)

[sivaraam]

@misaochan Sorry for the off-topic question. Why do you actually use the #assigned tag instead assigning the task to the concerned person?

[misaochan]

@sivaraam Because GitHub doesn't allow us to assign tasks to someone who hasn't yet contributed to the repo I believe. The option just isn't available.

[madhurgupta10]

Hi, if the issue is still not resolved, may I please work on it?

[misaochan]

@madhurgupta10 I think you can go for it, as @afswift hasn't been around for a couple months now. :)

[madhurgupta10]

@misaochan on it

[madhurgupta10]

@sivaraam Hi, could you please provide me the link for "Learn More" to "Use Wikidata" would cause huge data consumption.

So far, I have implemented the other changes

[misaochan]

Actually, I think "use Wikidata" can be removed entirely. We have migrated completely to Wikidata and do not even use the CSV anymore.(see #981 ). Also, I wonder if a "Location" subheader would be useful. Granted we will only have 1 item in it for the time being, but that would set "automatically get current location" apart from the other general settings.

[misaochan]

I noticed that you are missing "become a beta tester" and "send log file" - are they present but just not in your screenshot?

[madhurgupta10]

@misaochan they are present, but not in the screenshot

[madhurgupta10]

@misaochan Is there any code apart from the one in preferences.xml which is related to "use Wikidata", that should be removed?

[nicolas-raoul]

@madhurgupta10 I guess all CSV code has been removed, but f you find any such code please remove it, thanks :-)

[madhurgupta10]

@nicolas-raoul I made the necessary changes but one of the tests is failing, could you please help me debug!

[maskaravivek]

@madhurgupta10's PR fixes all the issues listed in @sivaraam's opening comment. Closing this issue. Thanks everyone for participating in the discussion and helping us improve our UI. :)