Apps-android-commons: Google Code-In: Setup development environment and run tests

[feelfreelinux]

• Download Android Studio 3.0
• Install and configure git on your machine
• Create github account
• Fork apps-android-commons repository on github
• Clone your fork into your local machine.
• Import your freshly cloned repository into Android Studio. This might take a while.
• Try to build and run app on your android device / emulator.
• In console run ./gradlew clean check connectedCheck jacocoTestReport --stacktrace to execute unit tests.
• Provide results of your tests, and screenshot of running instance. If any of unit tests are failing please document it in this issue.

Feel free to contact us if you have any problems.

[feelfreelinux]

@nicolas-raoul I've added this as beginner task on GCI dashboard, let me know if this suits you. I think that its really good introduction to git / github in general.

[nicolas-raoul]

While this does not add immediate new features to the app, it is a good exercise, don't hesitate to improve our wiki (do you have write access to it?) based on the difficulties they encounter, thanks a lot! :-)

[singh-anmol]

-GCI 2017-

Hello,
I am encountering build errors while running tests in Android Studio.
Simply running the app in emulator works. Only the command provided in GCI dashboard produces the error.
While test are running i can see some automated stuff happening in emulator like opening/closing of app (nearby) etc. (i also accepted some permission request)
sorry for the trouble, i'm new to android development.

Logs as requested -> https://pastebin.com/CshEhZva

[nicolas-raoul]

@feelfreelinux I let you check and approve the task. Please note that the unit tests are currently broken, so the result obtained by Singh is probably expected.

[singh-anmol]

@nicolas-raoul , @feelfreelinux - Sir, should i submit the task for review with the above results then?

[nicolas-raoul]

Let's wait for @feelfreelinux 's evaluation.

[feelfreelinux]

@nicolas-raoul @singh-anmol I just ran unit tests on my machine, can confirm this issue. You can submit task on GCI dashboard, and I will accept it :) Need to add note in task description that tests are currently broken

[psh]

There's a PR (#990) that addresses the broken test.

[nicolas-raoul]

@feelfreelinux I would highly suggest that you modify the task description to something like "1. Build, 2. Run the unit tests, 3. Tell us whether the unit tests are passing or failing"

Advantages of adding the 3rd step:

• You don't have to modify the description every time the tests fail or get fixed.
• More importantly, it teaches the students that unit tests are a way to get informed, not a thing that you perform because someone told you do so. A common problem is people running unit tests religiously but actually not caring whether they pass or fail: we want to avoid teaching them to be like that.
• It is actually rather informative (even though the same information is available through Travis when Travis is not down). Students can feel that their work is more useful than the many tasks that provide us zero value such as "Connect to IRC".

Also, I suggest using the expression "unit tests are failing" rather than "unit tests are broken", as far as I can tell it seems to be the right terminology, even though casual usage might differ :-)

Cheers!

[misaochan]

Tests should hopefully be passing now, sorry about that guys! (and thanks, @psh )

I agree with @nicolas-raoul 's suggestion for the 3rd step... the status of our tests can change fairly often.