Appcenter-cli: React Native - Deleting output folder after release

Created on 28 Nov 2017  路  7Comments  路  Source: microsoft/appcenter-cli

Hi!

Today I migrated from code-push-cli to appcenter-cli, but I'm having a problem, I use the generated bundle and sourcemap to upload them for sentry:

https://docs.sentry.io/clients/react-native/codepush/

But, in the final of the release process the appcenter-cli delete the generated folder:

https://github.com/Microsoft/appcenter-cli/blob/master/src/commands/codepush/release-react.ts#L153

I want to propose a flag to avoid delete the output dir, so I could keep the files after a release.

Most helpful comment

I merged the PR, I'll do a new release on Monday.

All 7 comments

Hi @renatoagds and thanks for submitting the issue. I've been fixed it here: #329 Do you have a chance to take a look at it and check whether it works for you or you have any more issues with that?

Please fix this :D It does not make sense that we are defining output directory and then it is deleted at the end :O We want also send our sourcemaps to Bugsnag

@ruslan-bikkinin hey! thanks for the quick response! I'll test today and send the feedback. 馃憤

@ruslan-bikkinin tested your branch and worked like a charm, waiting for a new release. 馃殌

Hi @christav, could you please merge this https://github.com/Microsoft/appcenter-cli/pull/329 PR in addition to this one https://github.com/Microsoft/appcenter-cli/pull/331 and probably make a new CLI release?

I merged the PR, I'll do a new release on Monday.

Release 1.0.6 is out with this fix. I'm closing this, if 1.0.6 doesn't fix the issue please reopen this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mirik999 picture mirik999  路  3Comments

kartikk picture kartikk  路  5Comments

dreamertheat picture dreamertheat  路  5Comments

xyashapyx picture xyashapyx  路  4Comments

dvdsgl picture dvdsgl  路  5Comments