Apollo-tooling: Bug: Wrong generated global type file import (Typescript)

Created on 21 Aug 2018  路  5Comments  路  Source: apollographql/apollo-tooling

Hi everyone :)

Since https://github.com/apollographql/apollo-cli/pull/520 by @danilobuerger landed I noticed the following:

When a globalTypes.ts file is generated and the the --outputFlat option is used, the outputPath is being ignored in generated type files (at least for the import statement of the globalTypes file).

It outputs:

import { SomeGlobalTypes, ShouldBe, Here } from "globalTypes";

when it should really be:

import { SomeGlobalTypes, ShouldBe, Here } from "./globalTypes";

Notice the incorrect path in the first example.

If you need more details, please let me know!

Most helpful comment

v1.7.1 has been published with the latest fixes included! Apologies for the late release, I just started college this week so my schedule's been packed with orientation activities.

All 5 comments

Duplicate of #543, fixed in #544

Yeah, this has been fixed a while ago (12 days ago) but it has not yet been published.

@shadaj is there anything preventing a new release? Would be awesome to have the fix published.

v1.7.1 has been published with the latest fixes included! Apologies for the late release, I just started college this week so my schedule's been packed with orientation activities.

Thank you!

I just started college this week so my schedule's been packed with orientation activities

@shadaj all the best for your college years! Have fun!

Was this page helpful?
0 / 5 - 0 ratings