Apollo-server: Playground: Resize schema panel

Created on 4 Apr 2019  路  11Comments  路  Source: apollographql/apollo-server

Now I' using apollo-server-express v2.3.1. I can resize the schema panel once but when I choose some query in the right then I can not resize it anymore and the panel returns to its original position.

I would be great if the schema panel could have the same resize functionality as editor panel and to persist the resize position if I refresh the page later.

馃浌 playground

Most helpful comment

@spencersteers Thank you for creating PR for fixing the regression I've introduced!

All 11 comments

The GraphQL Playground is actually a separate project under different ownership, located at https://github.com/prisma/graphql-playground.

Closing this for now - definitely an issue over on the project's repository if this is still a concern for you.

Maybe it's a problem of the Apollo Fork from the Prisma Playground. Because the current Prisma Playground v1.7.20 works correct.
With apollo-server-express: "2.6.9" it also works correct. But since v2.7.0 it doesn't work. If you try to change the schema panel size, you now get the following error in the console:

SideTabs.tsx:216 Uncaught TypeError: n.props.changeWidthDocs is not a function
    at HTMLDocument.i (SideTabs.tsx:216)

image

This issue still exists with:

apollo-server-express : 2.8.0
apollo playground fork: 1.7.30

@spencersteers The "prisma" link you've referenced above is not the current state of (their) master:

This is master (and a perma link to it at the time of this writing, just in case it changes)

Where did you get the 5fa7d83 Git hash that you referenced?

It looks like it was removed, relatively recently, in https://github.com/prisma/graphql-playground/pull/1001.

Perhaps @yoshiakis could provide some insight/justification on this?

@abernix My bad - not sure how I ended up there.

Looking at the latest release though the action is still being bound (v1.8.10 SideTabs.tsx)

Digging a bit deeper all the commits currently going into master have the resize issue. I pulled master and added the action back in and it seems to be working. Maybe master just isn't stable and it is on their radar.

@spencersteers Would you consider opening a PR for the fix to either the upstream or our fork (and maybe most preferably, out of a matter of timeliness, both?)

If you can, I can probably ship a patch for this fairly quickly.

@abernix Sure, can do.

@spencersteers Thank you for creating PR for fixing the regression I've introduced!

This should be fixed in the GraphQL Playground that's referenced from Apollo Server 2.9.1 if anyone wouldn't mind testing it and reporting back!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jpcbarros picture jpcbarros  路  3Comments

hiucimon picture hiucimon  路  3Comments

espoal picture espoal  路  3Comments

nevyn-lookback picture nevyn-lookback  路  3Comments

dbrrt picture dbrrt  路  3Comments