Apollo-ios: BUG: Writing to cache not throwing execution errors

Created on 5 Jun 2019  路  4Comments  路  Source: apollographql/apollo-ios

When there is an error executing a write to the cache, the error is being suppressed, even though the function is meant to throw.

In ApolloStore.swift on line 246, it should use await() instead of wait().

bug help wanted

All 4 comments

@AnthonyMDev Wanna put a PR together for this one? Would love to see this with a test that confirms an error is actually being thrown.

I would love to, but my companies policy requires me to submit a form for approval on open source libraries we contribute to. I'm sending in that form today, so hopefully I'll be able to start contributing shortly. I'll get a test and a fix in place as soon as that goes through.

Godspeed with the bureaucracy

I've been approved to contribute so I'll get a unit test and PR out to you today!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dmurph24 picture Dmurph24  路  4Comments

wnagrodzki picture wnagrodzki  路  4Comments

hiteshborse12 picture hiteshborse12  路  4Comments

sfla picture sfla  路  3Comments

vishal-p picture vishal-p  路  4Comments