Apollo-client: rc0 breaks our nextjs site

Created on 4 Jun 2020  路  6Comments  路  Source: apollographql/apollo-client

Intended outcome:
We were updating our apollo-client version to v3.0.0-rc.0 and expected it to work

Actual outcome:
Any call that used the apollo client timed out, which for us was server side rendered pages. We did not find any errors or log messages.

How to reproduce the issue:
We are currently in the process of investigation, but wanted to already alert the apollo-client team of this rc possibly silently breaking sites. I will update this issue if I figure out a way to reproduce this.

Our unit tests using a mocked schema did not break and were all green but when used against a real endpoint timeouts happen. There were no actual requests going out, as even if the graphql endpoint was not running it still timed out.

Versions
The issue was irrespective of os or browser and timed out in ssr rendered pages in nextjs
npmPackages:
@apollo/client: ^3.0.0-rc.0 => 3.0.0-rc.0
@apollo/link-schema: ^2.0.0-beta.3 => 2.0.0-beta.3
@apollo/react-common: ^3.1.4 => 3.1.4
@apollo/react-testing: ^3.1.3 => 3.1.4
apollo: 2.28.0 => 2.28.0
apollo-cache-inmemory: ^1.6.6 => 1.6.6
apollo-client: ^2.6.10 => 2.6.10
apollo-link-context: ^1.0.20 => 1.0.20
apollo-link-persisted-queries: ^0.2.2 => 0.2.2
apollo-link-schema: ^1.2.5 => 1.2.5
apollo-storybook-react: ^0.2.4 => 0.2.4
react-apollo: ^4.0.0-beta.1 => 4.0.0-beta.1

馃摕 regression

Most helpful comment

What version were you upgrading from? If you were previously using apollo-client (AC2), the new @apollo/client (AC3) package is a major update, with a number of absolutely necessary migration steps. Hopefully you already know this, but I honestly cannot guess this information from your description.

I was upgrading from beta.50 which was I believe a few days ago.

Reverting back to beta.50 fixes the problem.

All 6 comments

Looks like this ssr issue is reported on the Next repo, too: https://github.com/vercel/next.js/issues/13702

What version were you upgrading from? If you were previously using apollo-client (AC2), the new @apollo/client (AC3) package is a major update, with a number of absolutely necessary migration steps. Hopefully you already know this, but I honestly cannot guess this information from your description.

What version were you upgrading from? If you were previously using apollo-client (AC2), the new @apollo/client (AC3) package is a major update, with a number of absolutely necessary migration steps. Hopefully you already know this, but I honestly cannot guess this information from your description.

I was upgrading from beta.50 which was I believe a few days ago.

Reverting back to beta.50 fixes the problem.

@reggaemuffin If the problem has to do with SSR, then I believe #6388 may help (published in @apollo/[email protected] just now). Let us know!

This should be fixed in more recent versions of @apollo/client. Thanks!

I can confirm this, we updated to I believe rc30 and are on a working version that has this bug fixed :)

Was this page helpful?
0 / 5 - 0 ratings