Apollo-client: Write simple arrays to store

Created on 30 Mar 2016  路  9Comments  路  Source: apollographql/apollo-client

Currently there is an issue with writing simple arrays to the store. Arrays of objects work fine ([{}, {},]), but arrays of strings do not (['one', 'two',]). It throws this error:

TypeError: Cannot read property 'selections' of null

I played around in the tests, and it seems there is no issue reading an array of strings from the store once it is in there.

This seems like something it should support, and I'm going to work on a solution. Let me know if it's not. Thanks!

馃悶 bug

Most helpful comment

Just added you, and I made @jbaxleyiii an admin so that he can add additional collaborators if necessary!

All 9 comments

Yeah that makes sense! Just an oversight. Probably step 1 is to write a failing test for this case.

@stubailo already on it :)

This might mean we don't read those out of the store properly either, since the tests usually do both.

If you're going to work on it, please assign the issue to yourself!

@stubailo It doesn't look like I have permission to do that, but feel free to assign me

Just added you, and I made @jbaxleyiii an admin so that he can add additional collaborators if necessary!

Thanks!

@johnthepink this is fixed yes?

@jbaxleyiii yessir. Closed via #66

Was this page helpful?
0 / 5 - 0 ratings

Related issues

treecy picture treecy  路  3Comments

gregorskii picture gregorskii  路  3Comments

stubailo picture stubailo  路  3Comments

helfer picture helfer  路  3Comments

canercandan picture canercandan  路  3Comments