Apollo-client: Update to include typescript 1.8 features

Created on 25 Mar 2016  路  6Comments  路  Source: apollographql/apollo-client

'll do the update and list out the new features that are meaningful here. :+1:

_Note_
We have been using 1.8, but typescript just updated their site and have a good breakdown of 1.8 features. A few of them will be helpful here so I'll document them as tooling enhancements and open a corresponding PR with the adjustments

Most helpful comment

Oh, did you mean update to TS 1.8 new language features?

All 6 comments

Oh, did you mean update to TS 1.8 new language features?

@mquandalle yep! Wherever they can be applied!

Maybe one occurrence of that is in the GraphQL .d.ts interface definition, I think the following interfaces could be modified as follows:

    interface IntValue {
-       kind: string;
+       kind: "IntValue";
        loc?: Location;
        value: string;
    }

    interface FloatValue {
-       kind: string;
+       kind: "FloatValue";
        loc?: Location;
        value: string;
    }

ooh, that's neat. we should send a PR or something? or do these definitions want to be compatible with multiple versions of the language?

closing because it looks like we are already using everything useful

Was this page helpful?
0 / 5 - 0 ratings