Apollo-client-devtools: Stop working after latest release
Hi guys, apollo client devtools is not working correctly after the latest release, it crashes after trying to access the 'cache' tab, the cache doesn't open and the application freezes showing a black screen.
I'm using apollo v2
Great app btw :D
joanabeats
All 26 comments
Same problem with Apollo v3
eDubrovsky
on 29 May 2020
Thanks all - are you using Chrome or Firefox? And can you confirm the version is 2.3.0?
hwillson
on 29 May 2020
In my case with 2.3.0 and Apollo v3, I get the black screen on Queries tab while the cache works fine.
withinboredom
on 29 May 2020
Yes, version 2.3.0 and I'm using chrome v83
joanabeats
on 29 May 2020
Is there any chance someone here someone could provide a small runnable reproduction that breaks devtools? That would definitely help speed up troubleshooting.
hwillson
on 29 May 2020
It stopped working in my app
├── @apollo/[email protected]
├── @apollo/[email protected]
├── @apollo/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
and newest chrome.
Demo: https://ovgwz.csb.app/
https://codesandbox.io/s/react-apollo-with-hooks-ovgwz?file=/src/index.js
hinok
on 29 May 2020
@hinok Many thanks for adding the demo! When I view it using 2.3.0, the DevTools appear to be working. Could you describe what issues you're seeing?
jcreighton
on 29 May 2020
Below is what I'm seeing. If you are able to record what's happening, that will be helpful!
jcreighton
on 29 May 2020
@jcreighton
In my application I always get crash after clicking the "Cache" tab. On the video above you can see that sometimes it works, sometimes not.
hinok
on 29 May 2020
@hinok Super helpful! I'll keep digging around see if I can get this reproduced on my side.
jcreighton
on 29 May 2020
@jcreighton
In my application I always get crash after clicking the "Cache" tab. On the video above you can see that sometimes it works, sometimes not.
the same problem on macOS and Chrome Version 83.0.4103.61
eDubrovsky
on 29 May 2020
@jcreighton This is what I captured from the devtools devtools 💥
After clicking on Cache
hinok
on 29 May 2020
@hinok I saw that! Seems there some sort of race condition where value is set to null. I put up a PR: https://github.com/apollographql/apollo-client-devtools/pull/267
Would you be able to check it out and see if that fixes the issue?
jcreighton
on 29 May 2020
Ugh, I didn't mean to close the issue. Hit something with my wrist... 😆
jcreighton
on 29 May 2020
@eDubrovsky Are you able to build the extension and check as well?
jcreighton
on 29 May 2020
@jcreighton fixed, thank you! :)
eDubrovsky
on 29 May 2020
@joanabeats If you are able to check the related PR and let me know if it fixes the issue, that would be great!
jcreighton
on 29 May 2020
@jcreighton
Now it works 🥳
but... I think that we have another issue? I've never seen __schema in the cache panel. After clicking Cache, I need to wait 5-10s and finally get the view with __schema that contains a lot of things that shouldn't be in the cache.
On the first view, after refreshing the page everything looks good.
When I navigate to another page (new graphql queries are run), the devtools panel is frozen... seems that it's broken but after 5-10s it contains __schema.
It looks like the cache panel contains introspection query, correct me if I'm wrong.
hinok
on 29 May 2020
@hinok Thanks for checking out the PR and so happy it fixes the issue!
As for the __schema issue, that's working correctly. But there's an older opened PR to remove it (https://github.com/apollographql/apollo-client-devtools/pull/235). I'm newer to the project so I need some time to figure out the history of this and if we want to make that change (or why we wouldn't.)
jcreighton
on 29 May 2020
@joanabeats I've closed this for now and I'm working to get a 2.3.1 release out. If that doesn't solve the issue, we'll reopen this!
jcreighton
on 29 May 2020
@jcreighton I tested the PR, and is still crashing, it freezes a lot when opening the cache tab, I don't see the black screen but keeps freezing a lot now.
joanabeats
on 29 May 2020
@joanabeats Ok, thank you for testing it out! I'm unable to reproduce what you're seeing so if you could create a runnable sample, that would be ideal. You can also inspect the DevTools themselves and see if there's an error in the console.
jcreighton
on 29 May 2020
I'm not sure if this will help (probably wont because others have done the same), but just in case - here's a recording of the devtool's console while it crashes:
Also, a couple times it seemed to get into an infinite loop with thousands of the same error, before crashing. Couldn't consistently reproduce to get a recording, just thought it's worth mentioning.
EDIT: Oh, sorry - this PR hasn't been released yet.
ebrearley
on 31 May 2020
@jcreighton I test it again, it freezes mostly on cache tab, may be related with the new content that appears on the cache '__schema', and I also got this on the console :
VM1353:1 Uncaught TypeError: Cannot redefine property: __APOLLO_DEVTOOLS_GLOBAL_HOOK__
at Function.defineProperty (<anonymous>)
at <anonymous>:1:555
at <anonymous>:1:960
Tks.
joanabeats
on 1 Jun 2020
@joanabeats I've opened up a separate issue to track this since it's unrelated to the initial problem here.
jcreighton
on 1 Jun 2020
@joanabeats @hinok There's a PR related to #271 if you'd like to check it out.
jcreighton
on 2 Jun 2020
Related issues
iki
·
7Comments
raix
·
7Comments
jeffdesign
·
5Comments
robclouth
·
5Comments
nanandn
·
4Comments
Most helpful comment
@joanabeats I've closed this for now and I'm working to get a
2.3.1release out. If that doesn't solve the issue, we'll reopen this!