Apollo-android: RealApolloCall.toBuilder() does not respect useHttpGetMethodForQueries

[ubuntudroid]

Summary
When using RealApolloCall.toBuilder() the state of the useHttpGetMethodForQueries property is not set.

Version
2.3.0

Description
Steps to reproduce: call RealApolloCall.toBuilder() and check the returned builder. It doesn't take over the state of useHttpGetMethodForQueries from the original call instance.

The fix is quite simple, just call useHttpGetMethodForQueries(useHttpGetMethodForQueries) when constructing the builder.

I'll provide a PR.

[ubuntudroid]

@tasomaniac any idea when the next release will be? We rely on GET requests for our CDN to work properly and won't be able to roll out until this fix has made it into a release.

[martinbonnin]

I'm hoping to make a Kotlin 1.4 release as soon as SqlDelight is available for Kotlin 1.4, hopefully soon-ish.

In the meantime, any chance you can use ApolloClient.useHttpGetMethodForQueries as a workaround?

[ubuntudroid]

That unfortunately doesn't work for us as we are using toBuilder() to modify requests (which are configured via the configuration of the ApolloClient) before sending them. So we are always running into the bug. :(

[martinbonnin]

Got it. Let's wait until tomorrow night in hopes of a 1.4 SQLDelight release and if not there I'll make a patch release?

[ubuntudroid]

That would be awesome, thanks a lot! 🙏

[martinbonnin]

It's looking good for Kotlin 1.4 SqlDelight :-): https://github.com/cashapp/sqldelight/pull/1890, let's wait a bit more if you don't mind, I'll take a look tomorrow.

[ubuntudroid]

@martinbonnin Seems sqldelight has released their update. :)

[martinbonnin]

Yup, I'm on it, bintray is painfully slow but the first artifacts should be appearing on jcenter at the moment...

[martinbonnin]

And everything has made it to jcenter, let me know how it goes.

[ubuntudroid]

Looking good, many thanks! 🚀