Apollo-android: Use of absolute string path breaks generateSources task remote cacheability

Created on 20 May 2020  路  1Comment  路  Source: apollographql/apollo-android

Summary

Input property rootFolders is referenced as an absolute path string .

If you use a gradle remote cache absolute paths may differ based on the machine used for the build.

Description
I believe we could change this to a ConfigurableFileCollection similar to graphqlFiles fix the issue

Version
1.4.5, but pretty sure this is still on master.

gradle-plugin Bug
Source
picture BenSchwab
👍3

Most helpful comment

Good catch, thank! The reason rootFolders is a ListProperty<String> and not a List<DirectoryProperty> is that, in theory at least, the src/main/graphql folder can contain something else that .graphql files and we want the task to stay UP-TO-DATE even if an unrelated file changes.
This PR changes the paths so they are relative and the task can be relocable

picture martinbonnin on 21 May 2020
❤1 👍1

>All comments

Good catch, thank! The reason rootFolders is a ListProperty<String> and not a List<DirectoryProperty> is that, in theory at least, the src/main/graphql folder can contain something else that .graphql files and we want the task to stay UP-TO-DATE even if an unrelated file changes.
This PR changes the paths so they are relative and the task can be relocable

martinbonnin picture martinbonnin on 21 May 2020
❤1 👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

k-misztal picture k-misztal  路  3Comments
TonnyL picture TonnyL  路  3Comments
juliafu1 picture juliafu1  路  4Comments
TayfunCesur picture TayfunCesur  路  4Comments
jsiva001 picture jsiva001  路  4Comments