Apollo-android: Allow ApolloClient to be Proxied
https://github.com/spring-projects/spring-boot/issues/14879#issuecomment-430777067
Can ApolloClient please not be final, or maybe have a single interface that composes the 4 factory interfaces? Right now my client will be fine with just mutation, but if I wanted to do read/write in the same interface I'd have to inject 2 or more of them. Interface method is preferred, imho.
xenoterracide
All 5 comments
And final makes it hard to mock via mockito. Using mock-maker-inline as work around.
Hemantkumar-Chigadani
on 14 Dec 2018
you can make a single interface by extending the 4 interfaces. I'm not sure if conflating interfaces together for general use is what we want.
digitalbuddha
on 31 Dec 2018
yes, but I can't make your class use my interface, and it's final, thus I can't extend it... but you're right, that's how you would patch this... so what exactly do you expect? me to reimplement a full delegate? the real alternative to a 5th interface is to have the class not be final so proxies and mockito can extend it.
xenoterracide
on 31 Dec 2018
Misunderstood the issue sorry. Reopening
digitalbuddha
on 31 Dec 2018
Closing out of date. You can always mock raw http server request if needed with https://github.com/square/okhttp/tree/master/mockwebserver
sav007
on 13 Apr 2020
Related issues
pratthama-appdesk
路
3Comments
RageshAntony
路
3Comments
TonnyL
路
3Comments
john-lanticse
路
3Comments
AOrobator
路
3Comments
Most helpful comment
yes, but I can't make your class use my interface, and it's final, thus I can't extend it... but you're right, that's how you would patch this... so what exactly do you expect? me to reimplement a full delegate? the real alternative to a 5th interface is to have the class not be final so proxies and mockito can extend it.