Apollo-android: Publish jars instead of aars for the android modules

[VisheshVadhera]

See this: http://stackoverflow.com/questions/19307341/android-library-gradle-release-jar

[digitalbuddha]

What is the purpose of jar instead of aar?

On May 14, 2017 10:17 AM, "Vishesh Vadhera" [e-mail]
wrote:

See this: http://stackoverflow.com/questions/19307341/android-
library-gradle-release-jar

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/apollo-android/issues/492, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEUX3JUN4KyfRC-5DqaHPKJ58TlEAefBks5r5qqRgaJpZM4NaTHt
.

[VisheshVadhera]

aar would have made sense if we had android resources in our android modules, but since we don't, it's better to publish jar instead.

[jaredsburrows]

@VisheshVadhera Where would you use a Jar that contains Android code besides an Android application?

[VisheshVadhera]

We can publish aars, but the android modules don't really contain resources (layouts or strings), so I believe it's fine to publish jars instead.

[jaredsburrows]

I understand but since there is Android code in the jar/aar, it can only be consumed by an Android client such as another Android library or an Android application. Why change them from AAR to JAR? I am just not seeing the benefit.

[VisheshVadhera]

I don't really have a very strong opinion on aar vs jar. I was leaning slightly towards jar because of what I said above. But if we really don't see any benefit with jar, then we should probably close this issue. @sav007, do you have anything to add here before I close this one?

[digitalbuddha]

I vote aar since I think jar would make folks think it will work on just java projects

[sav007]

Yeah agree.

[jaredsburrows]

I know this is closed. I didn't have a good example before. I wanted to share this: https://github.com/bumptech/glide/issues/2318. We basically prevented issues like this from happening by closing this issue.