Apollo-11: Proof TRIM_GIMBAL_CNTROL_SYSTEM

Created on 20 Feb 2020  ·  9Comments  ·  Source: chrislgarry/Apollo-11

Proof read transcribed code of TRIM_GIMBAL_CNTROL_SYSTEM against scans

Lines: 622
Page: 1472—1485 (13)

Reduced quality scans can be found here

Moderate

All 9 comments

I would like to give this a go

Review completed. No discrepancies or issues.

Typo in file name (CNTROL instead of CONTROL)

image

There's some discrepancies with some equations in the comments (like line 136 ) and double dashes (--) instead of single dashes (-) among others from what I found with a cursory glance of a few pages

image
image

Thank you for pointing this out. Will start looking at file names in addition to the other things I missed.

i just realized that i failed to read CONTRIBUTING.md. Going to make sure and read this over. Thanks again for the feedback. This is a really fun project

Typo in file name (CNTROL instead of CONTROL)

image

Could you point me to where this is located? Just curious where i need to look to confirm the correct file name. Thanks

Typo in file name (CNTROL instead of CONTROL)
image

Could you point me to where this is located? Just curious where i need to look to confirm the correct file name. Thanks

First scanned page of each file (before 0001/R0001) - https://www.ibiblio.org/apollo/ScansForConversion/Luminary099/1472.jpg

added pr #756 hopefully everything looks okay

Was this page helpful?
0 / 5 - 0 ratings

Related issues

wmhilton picture wmhilton  ·  5Comments

mengzhibin picture mengzhibin  ·  4Comments

JackCapillary picture JackCapillary  ·  4Comments

lurch picture lurch  ·  5Comments

cjmielke picture cjmielke  ·  3Comments