Apm: Add INCLUDE_PROCESS_ARGS config option to all agents

Created on 4 Mar 2019 · 3Comments · Source: elastic/apm

Description of the issue

The Java agent is currently the only agent that has the INCLUDE_PROCESS_ARGS config option. What this option does is toggle whether or not the process object is added to the metadata event. If disabled, this in turn means that the APM Server will not attach the process information to each transaction and in turn save disk space.

If this makes sense for the Java agent, I don't see why we shouldn't add it to the other agents as well.

What we are voting on

@elastic/apm-agent-devs please vote on if you like to add this config option to your agent. If voting No or N/A, please add a comment explaining 😃

Vote

| Agent | Yes | No | Indifferent | N/A | Link to agent issue
| --------|:----:|:---:|:-----------:|:----:|:-------------------:|
| .NET |

|
| Go |

|
| Java |

|
| Node.js |

|
| Python |

|
| Ruby |

|
| RUM |

apm-agents poll

Source

watson

Most helpful comment

I seem to recall the reason for this is the Java agent's args list sometimes being hundreds of arguments? I don't immediately see why anyone would want this in Ruby.

Again, I'll bang my good old drum: Let's not add options _just because_. Ready to be voted down 😉

mikker on 4 Mar 2019

👍3

All 3 comments

I seem to recall the reason for this is the Java agent's args list sometimes being hundreds of arguments? I don't immediately see why anyone would want this in Ruby.

Again, I'll bang my good old drum: Let's not add options _just because_. Ready to be voted down 😉

mikker on 4 Mar 2019

👍3