Apm: APM fails on Windows when Atom location contains space character

[afrz]

Hello !

Prerequisites

• [ ] Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
• [ ] Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
• [x] Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
• [x] Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
• [x] Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Installation/update failure of atom-beautify 0.29.16 on Windows 7 x64.

Steps to Reproduce

1. Try to install 0.29.16 (through Atom GUI or apm CLI)
2. Installing “[email protected]” failed.

Expected behavior:

Installation ends successfully

Actual behavior:

Installation fails with following DEBUG output (see gist for full log)

'D:\Program' n'est pas reconnu en tant que commande interne

or in English :

'D:\Program' is not recognized as an internal or external command, operable program or batch file.

Reproduces how often:

100%

Versions

Windows 7 (64 bits)

atom --version
  Atom    : 1.12.7
  Electron: 1.3.13
  Chrome  : 52.0.2743.82
  Node    : 6.5.0

apm --version
  apm  1.12.9
  npm  3.10.5
  node 4.4.5
  python 2.7.11
  git 2.6.1.windows.1
  visual studio 2013

Additional Information

It seems that script build-options can not find a file located in 'Program Files' directory (which contains a space character).
For information Atom is installed in D:\Program Files\Atom\atom directory.

I notice that issue APM fails on Windows when the user's path contains special characters is fixed, but I do not know if it's the same problem (because user path vs. atom path)

[50Wliu]

/cc @damieng we had a previous report of this at #535.

[damieng]

I just tried this with a bunch of packages and didn't get any errors except on atom-beautify.

In fact all paths contain a space now on x64 Windows which I've been using for weeks.

I suspect this is an issue with atom-beautify especially given that it gets a lot of the way through and errors at;

> [email protected] postinstall f:\Temp\apm-install-dir-11703-8944-1kieqc0\node_modules\atom-beautify
> npm run build-options

'C:\Users\damien' is not recognized as an internal or external command,
operable program or batch file.
f:\Temp\apm-install-dir-11703-8944-1kieqc0
`-- (empty)

[Glavin001]

The problem is there is nothing Atom-Beautify can do to change it. All Atom-Beautify has is npm run build-options are a postinstall script within package.json, which is all fairly standard stuff. Then npm is translated into the absolute path -- which has the space -- and things start breaking. This is out of Atom-Beautify's control and appears to be in apm's realm.

Eventually Atom-Beautify will be removing the postinstall script, however, until that time this is something Atom-Beautify should be allowed to do without issue.

[damieng]

You're right -it's us getting in the way of the post-install scripts. Found, tested and fixed!

[damieng]

[Glavin001]

Wow, that was a quick fix. Awesome work!!! 🎆

[afrz]

Great news. Thanks you for your quick support. :+1:

You killed the beast ! :wink:

[Glavin001]

Is this released yet? How can users receive this fix? Thank you!

/cc @RockWolfHD

[pingshunhuangalex]

Hi @damieng

Just wonder when this fix will be pushed? I noticed it has a version no. of 1.15.2 which is really far away from the current 1.13.0 version. Thanks.

[damieng]

It should ship in the next 1.14 beta. No ETA on that right now.

On Sun, Jan 15, 2017, 10:14 PM Pingshun Huang [e-mail]
wrote:

Hi @damieng https://github.com/damieng

Just wonder when this fix will be pushed? I noticed it has a version no.
of 1.15.2 which is really far away from the current 1.13.0 version. Thanks.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/atom/apm/issues/666#issuecomment-272781766, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAHQp2q1rNQvryI9nuPHo1fr2BKiiOf0ks5rSwrJgaJpZM4LZg2-
.

[afrz]

For info, Atom version 1.14.1 has fixed the problem for me. Thanks again.