Apisix-dashboard: plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page
Issue description
plugin "proxy-rewrite" found in plugin-config detail page and not found in route detail page
Expected behavior
plugin "proxy-rewrite" both found or not found in plugin-config detail page and route detail page
How to Reproduce
When creating the route, the "proxy-rewrite" plugin was not found ï¼›
When creating the plugin-config, the "proxy-rewrite" plugin was found ï¼›
Screenshots
Environment
Additional context
xiaotaibai2008
All 8 comments
"Request Override" is the proxy-rewrite plugin #1576
Engine-AI
on 8 Apr 2021
yes, this plugin is out of box.
juzhiyuan
on 8 Apr 2021
yes, this plugin is out of box.
I have a problem. I can search the rewrite plugin on the route view page，But I don't know it is a bug or a feature。
Engine-AI
on 8 Apr 2021
Route View? Could you please take a screenshot?
juzhiyuan
on 8 Apr 2021
As we have removed the proxy-rewrite plugin out of step3 of /routes/create page, it should not be found in this page, after checking the latest code, the current implementation matched the expectation.
I have a problem. I can search the rewrite plugin on the route view page，But I don't know it is a bug or a feature。
while checking this issue, I found that in the step2 of /plugin-template/create page, proxy-rewrite can still be found, that is not as expected, #1723 will fix this. So can this solve your problem @Abbila ?
plugin "proxy-rewrite" both found or not found in plugin-config detail page and route detail page
plugin-config detail page means /plugin/market right @xiaotaibai2008 ? If so, IMHO proxy-rewrite can be found is as expected, because in this page, plugin is configured for the global, not only for the route, so just keep it in.
liuxiran
on 8 Apr 2021
@liuxiran @juzhiyuan When editing the route, proxy-rewrite can be found on the preview page of the route, which is the fourth step。
Engine-AI
on 9 Apr 2021
@liuxiran @juzhiyuan When editing the route, proxy-rewrite can be found on the preview page of the route, which is the fourth step。
good catch @Abbila ~ there is a missing modification in https://github.com/apache/apisix-dashboard/blob/166137ea9fa42694f09beca3c5c19335b20abc6f/web/src/pages/Route/components/CreateStep4/CreateStep4.tsx#L62
liuxiran
on 9 Apr 2021
@liuxiran Already resolved in #1721 ，
Engine-AI
on 12 Apr 2021
Related issues
stu01509
·
3Comments
membphis
·
6Comments
juzhiyuan
·
3Comments
juzhiyuan
·
4Comments
bisakhmondal
·
5Comments
Most helpful comment
As we have removed the
proxy-rewriteplugin out of step3 of/routes/createpage, it should not be found in this page, after checking the latest code, the current implementation matched the expectation.while checking this issue, I found that in the step2 of
/plugin-template/createpage,proxy-rewritecan still be found, that is not as expected, #1723 will fix this. So can this solve your problem @Abbila ?plugin-config detail pagemeans/plugin/marketright @xiaotaibai2008 ? If so, IMHOproxy-rewritecan be found is as expected, because in this page, plugin is configured for the global, not only for the route, so just keep it in.