Apisix-dashboard: The upstream timeout unit is seconds instead of milliseconds

Created on 9 Mar 2021  路  9Comments  路  Source: apache/apisix-dashboard

image

bug frontend good first issue
Source
picture dickens7

All 9 comments

thanks for feedback, we will recheck it.

nic-chen picture nic-chen on 9 Mar 2021

@nic-chen any update about this? should it be seconds or milliseconds?

juzhiyuan picture juzhiyuan on 9 Mar 2021

@juzhiyuan it's in seconds. see:

https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L108
https://github.com/apache/apisix/blob/master/apisix/balancer.lua#L23

https://github.com/openresty/lua-resty-core/blob/master/lib/ngx/balancer.md#set_timeouts

nic-chen picture nic-chen on 9 Mar 2021

OK

juzhiyuan picture juzhiyuan on 9 Mar 2021

I want to fix this issue, please assign this issue to me.

stu01509 picture stu01509 on 11 Mar 2021
👍1

ok, thanks. @stu01509

nic-chen picture nic-chen on 11 Mar 2021
👍1

@stu01509 have you resolved the issue. if not then i would like to work on it
@nic-chen

iamayushdas picture iamayushdas on 11 Mar 2021
👍1

ping @stu01509

nic-chen picture nic-chen on 12 Mar 2021
👍1

Hi @nic-chen sir

I sent the PR, Please review it :)

stu01509 picture stu01509 on 12 Mar 2021
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

juzhiyuan picture juzhiyuan  路  3Comments
stu01509 picture stu01509  路  3Comments
gxthrj picture gxthrj  路  5Comments
aiyiyi121 picture aiyiyi121  路  4Comments
chenyicai picture chenyicai  路  4Comments