Apisix-dashboard: Clicking on a mask while editing a plugin does not allow the drawer to be closed

Created on 3 Mar 2021  路  5Comments  路  Source: apache/apisix-dashboard

Feature request

Users may click on the mask by mistake when editing complex plugins, and the drawer will close after clicking on the mask, resulting in the loss of data edited by the user.
image

Describe the solution you'd like

Clicking on the mask does not allow the drawer to be closed

We can set maskClosable to false to do this.

Refer link: https://ant.design/components/drawer/#API

cc @tokers

frontend good first issue

All 5 comments

agree +1

Yeah, it sounds logical. Can I work on this issue, @LiteSun, @nic-chen? I also noticed that editing any existing plugins also result in the same behaviour. Should I restrict that too?

Edit: I have made the changes. Can I open a PR?

Yeah, it sounds logical. Can I work on this issue, @LiteSun, @nic-chen? I also noticed that editing any existing plugins also result in the same behaviour. Should I restrict that too?

sure, welcome.

Yeah, it sounds logical. Can I work on this issue, @LiteSun, @nic-chen? I also noticed that editing any existing plugins also result in the same behaviour. Should I restrict that too?

Edit: I have made the changes. Can I open a PR?

Looking forward to your PR! 馃帀

Hello guys!! Just opened it :)
Waiting for the review, hehe. Thanks for the super quick reply.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Applenice picture Applenice  路  4Comments

qian0817 picture qian0817  路  4Comments

bisakhmondal picture bisakhmondal  路  5Comments

nic-chen picture nic-chen  路  6Comments

juzhiyuan picture juzhiyuan  路  5Comments