Api: Forge Activities are Mode 0 And Always Show Successful Completion

[TorKallon]

The PGCRs for Forge activities:

• are currently returning 0 mode
• no other modes in the mode list
• all show success even when the activity failed

[vthornheart-bng]

Ooh, thanks for the info - I'll give that a look too!

[floatingatoll]

Note that, in-game, the activity “completes”, with a countdown to orbit and everything — by standard generic activity definitions, it terminates normally and properly.

I believe the desire is to evaluate whether a forge activity was “completed” rather than “failed” from an in-activity perspective - killed the final whatever, got the final loot - rather than from a generic “activity concluded without interruption” perspective.

On Dec 26, 2018, at 16:07, Vendal Thornheart [e-mail] wrote:

Ooh, thanks for the info - I'll give that a look too!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[vthornheart-bng]

Good to know, thank you!

[TorKallon]

To @floatingatoll 's point, not that there is a way to normally see the difference between "completed" and "successfully completed." For example, the old timed Nightfalls would be completed if you ran out of time but didn't kill the boss. But completionReason.value.basic would be 1 if it was failed and 0 if it was successful. In the case of Forge activities completionReason is always 0, showing success even if you fail to kill the boss.

[jshaffstall-bng]

Following up on this many months later, Forge activities now have their own activity mode, and you should be able to see differences between successful and failed completions with the 'completionReason' stat.
EDIT: Actually, maybe not with the completion reason. But you should see a completionReason of 255 when someone leaves.

[TorKallon]

Will this be retroactive?

On Wed, May 8, 2019 at 4:01 PM jshaffstall-bng [e-mail]
wrote:

Following up on this many months later, Forge activities now have their
own activity mode, and you should be able to see differences between
successful and failed completions with the 'completionReason' stat.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Bungie-net/api/issues/835#issuecomment-490682527, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABVGFYSTVZGBTYAETKICDLPUNLUPANCNFSM4GMIV3FQ
.

[jshaffstall-bng]

I'm seeing Forge activity modes back to January 2019, but I don't know if you'll get Forge activities the same way from December 2018.

[KiaArmani]

This issue still exists. I am getting this for both a successful and failed forge.

 "completionReason": {
                        "basic": {
                            "displayValue": "Objective Completed",
                            "value": 0
                        }
                    }