Api: Transferring items to characters using API returns in repeated in-game "Triumph completed" toasts

Created on 5 Sep 2018  ·  19Comments  ·  Source: Bungie-net/api

Whenever i transfer gear to my _other_ characters, which I have not yet logged in since Tuesday's 2.0.1 patch, I the game shows "Triumph completed" toast notifications at the bottom of the screen. This happens multiple times.

The notifications look like they're for completing lost sectors, one for each destination. Transferring multiple items results in duplicate toasts.

Video https://youtu.be/XMzRCqaJC_E

bug bug filed investigation

Most helpful comment

For anyone looking at this issue, I spoke a little bit on Reddit about what's happening - it's pretty interesting! Here's the scoop:

So to understand what's happening here, the first thing that's important is that many parts of the game - such as the triggers that activate Triumph "toast" messages - are activated as the result of some internal state crossing a numerical threshold. This internal state can be stored in a variety of places, but the most common two are on your Account (thus accessible across all characters) and on each of your characters separately.

Sometimes, this state is updated by checking and aggregating the values from many other states. This check and aggregation tends to happen when the values in question change, as well as during certain transition periods such as log in, log out, or when your data is accessed via the API (as part of a process that is also checking for whether your daily/weekly/etc... resets should be getting run).

In the case of lost sectors, there's a bunch of (for lack of a better word) "flags" that indicate whether you've ever found those sectors. There's also a single state that's counting how many of those flags are set. The bug here is that those flags being counted are on your character, and the single state counting how many are set are on your account.

When you perform a transfer that interacts with a character that's not the one you have logged in and are actively playing the game, these counts run: but they run under the context of the not logged-in character. This updates the account-stored value being used to determine whether the threshold has been crossed to show the Triumphs toast messages.

For a more concrete example: Let's say you need 5 and on your logged-in Titan you've done all 5, but on your Hunter you only have 2. If you interact with your Hunter through the API while logged into your Titan, those counts run - but because they're erroneously mixing character and account-level state, they're re-counting in the context of the hunter. The count state on your account gets updated to 2. Now, the next time that count is performed on the Titan - if you go to orbit, or if you then transfer an item using the API from the vault to the Titan - the count gets run again in the context of the Titan and the count goes back to 5. The threshold is crossed, and the game launches the "Triumphs" toast.

So when you see that message coming up, that's what's happening under the hood - and why the workaround is effective. If you go find all the lost sectors with all your characters, the count never falls under the threshold: so even though it's being re-evaluated, it no longer triggers the Triumphs toast!

All 19 comments

Bringing this up with some folks now.

The game side folks are looking into it: for now, it's out of my hands. But I'll let you know if they come up with something.

For what it's worth, today I started playing Forsaken on my Hunter alt and this still happens when I transfer items from my Warlock (which has now completed Forsaken campaign) to my Hunter.

I still have a Titan which hasnt opened Forsaken yet.

Same here on all counts - tons of in-game notifications when this happens.

Is there any news on if this is going to be fixed? I get daily mails about it

I've heard nothing since my initial report. Hang tight, I will try to get an update.

Ah, well that's part of the problem. I had messaged someone, but never formally made a bug. I had been told this was being investigated, but I'm not sure what that progress is - I've made a new bug and will try to pass that around to folks in order to find out what's up.

TFS 721517

The short-term fix for this issue is to complete all the requirements for the Triumphs (that you are seeing when transferring items) on all characters. Once I completed all the Lost Sectors and region chests on all the old areas on all characters I no longer see the triumph alerts when transferring items. Tangled Shore appears to be tracked differently as a single character having all the region chests does not cause the Triumph to show up as it did for previous areas.

For diagnostic purposes, this issues occurs even when the other two
characters have never logged into Destiny 2 at all (imported from D1).
On Mon, Oct 15, 2018 at 12:01 PM ericleone notifications@github.com wrote:
>

The short-term fix for this issue is to complete all the requirements for the Triumphs (that you are seeing when transferring items) on all characters. Once I completed all the Lost Sectors and region chests on all the old areas on all characters I no longer see the triumph alerts when transferring items. Tangled Shore appears to be tracked differently as a single character having all the region chests does not cause the Triumph to show up as it did for previous areas.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Just an update on this - indeed, we aren't going to have a game-side fix for this in the near future unfortunately. They're working on a fix, but it's targeted for early in the new year. I apologize to anyone experiencing this issue: we've got no good workaround aside from the painful one recommended above by @ericleone.

I'm still seeing this at least once a night, but it's just a mild annoyance. Clearly I need to play more so I can clear out those triumphs, haha. Thanks!

For anyone looking at this issue, I spoke a little bit on Reddit about what's happening - it's pretty interesting! Here's the scoop:

So to understand what's happening here, the first thing that's important is that many parts of the game - such as the triggers that activate Triumph "toast" messages - are activated as the result of some internal state crossing a numerical threshold. This internal state can be stored in a variety of places, but the most common two are on your Account (thus accessible across all characters) and on each of your characters separately.

Sometimes, this state is updated by checking and aggregating the values from many other states. This check and aggregation tends to happen when the values in question change, as well as during certain transition periods such as log in, log out, or when your data is accessed via the API (as part of a process that is also checking for whether your daily/weekly/etc... resets should be getting run).

In the case of lost sectors, there's a bunch of (for lack of a better word) "flags" that indicate whether you've ever found those sectors. There's also a single state that's counting how many of those flags are set. The bug here is that those flags being counted are on your character, and the single state counting how many are set are on your account.

When you perform a transfer that interacts with a character that's not the one you have logged in and are actively playing the game, these counts run: but they run under the context of the not logged-in character. This updates the account-stored value being used to determine whether the threshold has been crossed to show the Triumphs toast messages.

For a more concrete example: Let's say you need 5 and on your logged-in Titan you've done all 5, but on your Hunter you only have 2. If you interact with your Hunter through the API while logged into your Titan, those counts run - but because they're erroneously mixing character and account-level state, they're re-counting in the context of the hunter. The count state on your account gets updated to 2. Now, the next time that count is performed on the Titan - if you go to orbit, or if you then transfer an item using the API from the vault to the Titan - the count gets run again in the context of the Titan and the count goes back to 5. The threshold is crossed, and the game launches the "Triumphs" toast.

So when you see that message coming up, that's what's happening under the hood - and why the workaround is effective. If you go find all the lost sectors with all your characters, the count never falls under the threshold: so even though it's being re-evaluated, it no longer triggers the Triumphs toast!

To ask an odd question: Is this related to why flying into the Tower triggers "Lost Sector Discovered" in-game sometimes too?

If it's happening after you transfer an item from a not-logged-in character to your vault, indeed it is!

EDIT: Oh, wait - I thought you meant the lost sector Triumphs pop-up. If it's the lost sector discovered HUD element... I don't know for certain if it's related.

Without news?

Sometimes the same message pops on screen, once for each item transfered. A possible workaround is ignore all repeated messages in each character session. Is it possible?

Hi, this came up on Reddit a couple times recently. The general tone seems to be “Will this ever be fixed?”; while I don’t endorse that phrasing, duly noted (and if someday you find that this will _not_ be fixed, please do let us know).

This should be fixed up as of a few weeks ago!

Good news everyone! It's back! Same conditions to trigger as before. Same symptoms "TRIUMPH: Lost Sectors completed: Titan" and so on. Please reopen/open bug as appropriate, as this is a regression corresponding to roughly Shadowkeep release time frame.

Yes, we're tracking this after getting some reports on Reddit about it a few days ago. The introduction of Interval Triumphs apparently caused a break in the prior fix. A fix is checked in, but unfortunately it required a game-side change. We won't be seeing the change actually go live until the game's winter release, so sometime in December. Bummer.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

andyschott picture andyschott  ·  3Comments

theoperatore picture theoperatore  ·  4Comments

justrealmilk picture justrealmilk  ·  3Comments

pancakeslp picture pancakeslp  ·  3Comments

ttgmpsn picture ttgmpsn  ·  3Comments