Api: Character order is not returning in Order of Creation

[SunburnedGoose]

Users could sort their characters by order of creation but this is not working at the moment.

[vthornheart-bng]

Sweet, thank you! I will have to take a look at this, I have a strong suspicion about the janky issue causing this to occur.

[vthornheart-bng]

Since it's currently broken anyways, I suppose this is a good time to ask: do you all prefer it being returned in order of creation?

Order of creation makes it consistent and reliable, which I think is a strong benefit. There are other ways of sorting (most recent etc...) that might have benefits as well however. I'd be interested in folks' thoughts! Right now I lean toward order of creation still for the sake of that consistency, but if another order would make most users' lives easier perhaps we could roll with that.

[nine13tech]

EMPHATICALLY YES!!!
<img thingy> fry, shut up and take my money</img thingy>

[vthornheart-bng]

Emphatically yes to keeping order of creation?

And just to make 100% sure we're all talking about the same thing, we're talking about the ordering of DestinyProfileComponent.characterIds?

[vthornheart-bng]

Fixed for the deployment next week! Yeah... it's tempting to do something other than order of creation, but now that I think about it the consistency feels more important.

[vthornheart-bng]

In the meantime if you want a manual workaround, note that characterIds are actually created in ascending order: so lower IDs are, by definition, older than newer IDs. If you sort by character ID ascending you can emulate what I'll be returning in this fix.

[JacobCallahan]

@vthornheart-bng I agree that order of creation is likely the best route forward. Either way, consistency is definitely key! Thanks for the quick fix :100:

[justrealmilk]

It’d be cool to add dateCreated tbh. Another data point to show and could be used to order characters but that said since IDs are created in ascending order maybe it’s a little redundant

---

From: Jacob Callahan [e-mail]
Sent: Thursday, August 30, 2018 12:11:36 AM
To: Bungie-net/api
Cc: Subscribed
Subject: Re: [Bungie-net/api] Character order is not returning in Order of Creation (#614)

@vthornheart-bnghttps://github.com/vthornheart-bng I agree that order of creation is likely the best route forward. Either way, consistency is definitely key! Thanks for the quick fix 💯

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/Bungie-net/api/issues/614#issuecomment-416967742, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAJkCQqEuHPlv8y3_t_K_CvTKiWrG_Roks5uVqEYgaJpZM4WQjEJ.

[ckhicks]

I generally do the date math for last active, which is almost always what I'm actually looking for, but +1 to having the consistency as a known factor definitely being more important.

[nine13tech]

@vthornheart-bng - Yes order of creation in the DestinyProfileComponent.characterIds

[bhollis]

@vthornheart-bng we're getting reports that this still isn't in the order of character creation.

[floatingatoll]

I’ll record another report of this _not_ being fixed anymore as well.

On Sep 22, 2018, at 19:38, Ben Hollis [e-mail] wrote:

@vthornheart-bng we're getting reports that this still isn't in the order of character creation.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[vthornheart-bng]

Can either of you give me an account ID that is experiencing the issue? We're literally just returning the character IDs in ascending order, which should match the order of character creation as those identifiers are also created in ascending order as people make accounts. If you've found an example where that's not true, definitely pass it my way so I can investigate!

[stevennic22]

I'm currently experiencing this on DIM and Ishtar. Main companion app appears to be working as expected.

Only occurs with Battlenet account. Xbox account is working as expected.

Profile: https://bungie.net/en/Profile/4/4611686018467547676/Schmoops22

[vthornheart-bng]

Sweet, thank you! I'll give it a look!

[vthornheart-bng]

Well son of a gun, you're right. Thank you, this is the data point I was looking for. Indeed, it does look like this heuristic I'm using is not sufficiently reliable. I am not certain of the circumstances in which this could occur, but I'm seeing the evidence of it there in your account.

I'm going to have to do some digging. I can't promise that there's going to be a good resolution for this: we don't have the character's actual creation date in the data that we have access to in the backend, and without that and with the character ID not being reliable in every scenario as a determinant of date order, I'm not sure that we can provide the creation date ordering that I thought we'd be able to.

I'll do some investigating, and ask around to see if creation date could be something that we could get access to for this purpose.

Again, thanks for the data point! That was most helpful.

[vthornheart-bng]

I've made a bug to track this request, TFS 718354.

[vthornheart-bng]

Ooh, actually we may have a solution by coincidence. I've got to do some edge case testing.

[vthornheart-bng]

Okay, so here's the scoop:

There are edge cases where users can indeed create characters with out-of-order character Ids. A certain set of specific circumstances have to occur in how they're routed in our backend during and between the creation of those characters for it to occur, but the proof is in the pudding that this happens in practice.

I should be able to get us the order in a reliable way once more, but it's going to require me to go in and make changes to a deeper system. The soonest window that I'd be allowed to do this will likely be December at this point, but I will keep you posted.

I'm going to leave the fix I've already made as-is for now, as for the majority of players should have a much more consistent experience with the existing fix. For the remaining players for whom this is happening, they will unfortunately have to wait for this deeper fix.

[SunburnedGoose]

Thanks. This has been our experience too, with PC players having out of
order characters. We will let players sort their characters to resolve the
issue on our side.

On Wed, Oct 3, 2018 at 3:11 PM Vendal Thornheart [e-mail]
wrote:

Okay, so here's the scoop:

There are edge cases where users can indeed create characters with
out-of-order character Ids. A certain set of specific circumstances have to
occur in how they're routed in our backend during and between the creation
of those characters for it to occur, but the proof is in the pudding that
this happens in practice.

I should be able to get us the order in a reliable way once more, but it's
going to require me to go in and make changes to a deeper system. The
soonest window that I'd be allowed to do this will likely be December at
this point, but I will keep you posted.

I'm going to leave the fix I've already made as-is for now, as for the
majority of players should have a much more consistent experience with the
existing fix. For the remaining players for whom this is happening, they
will unfortunately have to wait for this deeper fix.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Bungie-net/api/issues/614#issuecomment-426783819, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA8GIJKe0TsUdzXLfQp1UJ082Klpbp1Rks5uhRoIgaJpZM4WQjEJ
.

[stevennic22]

I would like to make a correction (if it helps anything): For my Battlenet account on the Bungie website directly, it appears to load in the correct order (and doesn't appear to be driven by the most recently used/controlled character or PL).

Is there something different in how the website is pulling/showing the information vs the apps/API?