Api: Feature Request: add season property to all inventory items

[delphiactual]

If each item had a season property searching for certain items would be easier

[floatingatoll]

I think it would go down like this:

1) the armor is either “no season” or “season 1”, and

2) ornaments are plugged into the item in a specific location in its JSON, and so

3) both the armor item properties and the specific unplugged ornament’s item properties would each have a season property, and

4) the ornament plug within the armor item would retain the season property originally held by the unplugged ornament item

On Jul 11, 2018, at 05:08, duckmanBR [e-mail] wrote:

But how would we set this property? This info is being returned by the API now?
Also, how would we handle seasonal ornaments? The armor would be season 1, but would also return true for other seasons if the it had a completed Season X ornament?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[duckmanBR]

Deleted my original coment because I thought that @delphiactual issue was posted on DIM github :confounded:

Just to keep it together, part of my original comment (and that @floatingatoll based his comment on) was how would we handle armors (that are mostly from season 1) with ornaments that are from subsequent seasons.

[floatingatoll]

It’s still a terrifically valuable thing to consider, in any case!

On Jul 11, 2018, at 07:30, duckmanBR [e-mail] wrote:

Deleted my original coment because I thought that @delphiactual issue was posted on DIM github 😖

Just to keep it together, part of my original comment (and that @floatingatoll based his comment on) was how would we handle armors (that are mostly from season 1) with ornaments that are from subsequent seasons.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[vthornheart-bng]

Hmm, an interesting proposal - I'd like to look into it if we get some time, though right now we're still knee deep in Forsaken work.

[delphiactual]

https://github.com/delphiactual/d2-seasons-redis

[delphiactual]

632