Howdy! @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud, @lingyv-li, @marcospassos
We've got new DART target and es6 stuff to release. You've also had lots of interesting PRs related to the other targets.
Let's move towards a 4.9 release. What do we have outstanding that needs to go in?
Thanks!
parrt
All 37 comments
I have 2 PRs open for the C++ target. One is the small doc fix (#2923) and the other that cmake fix (#2913). Nothing else from my side.
mike-lischke
on 5 Oct 2020
Anybody else have stuff?
parrt
on 10 Oct 2020
Give me a couple of days to go through the PRs
Le 10 oct. 2020 Ă 09:23, Terence Parr notifications@github.com a Ă©crit :
Anybody else have stuff?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/antlr/antlr4/issues/2932#issuecomment-706462764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNQJF2D2ESNJNOZHW2LU3SJ6ZSDANCNFSM4SDZEWEA.
ericvergnaud
on 10 Oct 2020
I don't have any time available for this project at the moment, I'm afraid. I haven't looked at any PRs since the last release.
ewanmellor
on 11 Oct 2020
No problem, @ewanmellor !
parrt
on 11 Oct 2020
Nothing interesting happened to the PHP target recently. We intend to put some effort into performance in the next months, but nothing to be part of 4.9.
marcospassos
on 14 Oct 2020
looking forward to the 4.9 version !
zekunyan
on 20 Oct 2020
Nothing interesting happened to the PHP target recently. We intend to put some effort into performance in the next months, but nothing to be part of 4.9.
Hi, when do you plan v4.9 release ? Maybe it's not too late for create PR solving #2709 :wink:
adamwojs
on 20 Oct 2020
Haven't heard anything abnormal with Dart target yet, I think there is nothing else for this release for Dart.
lingyv-li
on 20 Oct 2020
@adamwojs I'll wait to see if a PR pops up for #2709.
@ericvergnaud: am I caught up with your PR merges?
parrt
on 20 Oct 2020
@parrt PR #2901 #2809 #2819 and #2781 seem to have introduced non-intrusive changes and would be safe to merge if rebase looks good.
hanjoes
on 20 Oct 2020
@hanjoes done!
parrt
on 20 Oct 2020
@parrt Absolutely amazing news on the new Dart target. Any idea of the timeframe until 4.9 is out? I'm absolutely desperate to use the Dart target for a new project I'm working on.
gkjpettet
on 22 Oct 2020
Hi @gkjpettet i'm stuck teaching at moment. a few more PRs and I guess we can call it quits
parrt
on 22 Oct 2020
@parrt Thanks, not just for responding but for the ANTLR project in general. I’ve only recently discovered it but it is a fantastic piece of work.
gkjpettet
on 22 Oct 2020
Ok gang. @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud, @lingyv-li, @marcospassos @davesisson I think next week during the US Thanksgiving holiday I will try to push out 4.9. thanks for all your efforts.
parrt
on 20 Nov 2020
Great!
Le 21 nov. 2020 Ă 01:46, Terence Parr notifications@github.com a Ă©crit :
Ok gang. @pboyer https://github.com/pboyer, @mike-lischke https://github.com/mike-lischke, @janyou https://github.com/janyou, @ewanmellor https://github.com/ewanmellor, @hanjoes https://github.com/hanjoes, @ericvergnaud https://github.com/ericvergnaud, @lingyv-li https://github.com/lingyv-li, @marcospassos https://github.com/marcospassos @davesisson https://github.com/davesisson I think next week during the US Thanksgiving holiday I will try to push out 4.9. thanks for all your efforts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/antlr/antlr4/issues/2932#issuecomment-731309461, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNQJEWN7B7CRM7POZQY43SQ2TOZANCNFSM4SDZEWEA.
ericvergnaud
on 21 Nov 2020
ok, I'm starting now. must swap all of the deployment knowledge back into my head from cold storage. haha
Added 4.9 tag to appropriate issues and pull requests. will try a release candidate build.
parrt
on 24 Nov 2020
Okay I decided to not do a release candidate and just push out 4.9. it should be at maven now if you want to take a look at it. I'm working on updating the website and adding jars etc. will build the individual targets next.
parrt
on 24 Nov 2020
parrt
on 24 Nov 2020
Ok, @lingyv-li you will have to publish DART target as I don't have access.
I'm waiting on appveyor to create a build for C#
parrt
on 24 Nov 2020
@parrt I have published 4.9.0. Your Google account parrt cs.usfca.edu should have admin access to the package. Please let me know if it doesn't work.
lingyv-li
on 24 Nov 2020
Ah. well, I don't have pub for dart on my command line, which is all the instruction I have written down. :(
parrt
on 24 Nov 2020
@marcospassos unfortunately it looks like I've screwed up this submodule thing again. here is what appveyor looks like:
Build started
git clone -q --branch=master https://github.com/parrt/antlr4.git C:\projects\antlr4-l7imv
git checkout -qf 954c5fab1c5abe4fa7c4241f7bfde48de7a9966b
Restoring build cache
Cache 'C:\Users\appveyor\.m2' - Restored
Cache 'C:\Users\appveyor\.nuget\packages' - Restored
Running Install scripts
git submodule update --init --recursive
Submodule 'runtime/PHP' (https://github.com/antlr/antlr-php-runtime.git) registered for path 'runtime/PHP'
Cloning into 'C:/projects/antlr4-l7imv/runtime/PHP'...
fatal: remote error: upload-pack: not our ref 6c0287e9a5be50d71578436aed99972ed23f73e0
fatal: the remote end hung up unexpectedly
Fetched in submodule path 'runtime/PHP', but it did not contain 6c0287e9a5be50d71578436aed99972ed23f73e0. Direct fetching of that commit failed.
Command exited with code 1
@amorimjuliana can you help?
parrt
on 24 Nov 2020
Ok, somebody's going to have to build the C# package. I literally can't get that unbelievable piece of shit appveyor to work. Has anybody but me noticed that none of the messages correspond correctly to the commits or whatever? all of them are nonsense:
Seriously. WTF?! It says 4.7.1 etc..?
it looks like I might have kicked off a bill that is now working after futzing with the stupid git submodule shit. unfortunately it is for the next snapshot build 4.9.1 not 4.9.
parrt
on 24 Nov 2020
@marcospassos can you check the php target? See errors here https://ci.appveyor.com/project/parrt/antlr4-l7imv/builds/36494430
ANTLR Tool version 4.9 used for code generation does not match the current runtime version 4.8 in C:\projects\antlr4l7imv\runtime\PHP\src\RuntimeMetaData.php on line 140
damn. seems the submodule shows:
public const VERSION = '4.8';
@ericvergnaud does this package look right?
Antlr4.Runtime.Standard.4.9.0.nupkg.zip
Hmm..That's risky as it came from this PR https://github.com/antlr/antlr4/pull/2908
parrt
on 26 Nov 2020
Just updated it. Can you update the submodule? It should work now.
On Wed, Nov 25, 2020 at 20:08 Terence Parr notifications@github.com wrote:
@ericvergnaud https://github.com/ericvergnaud does this package look
right?
Antlr4.Runtime.Standard.4.9.0.nupkg.zip
https://github.com/antlr/antlr4/files/5599734/Antlr4.Runtime.Standard.4.9.0.nupkg.zip—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/antlr/antlr4/issues/2932#issuecomment-734000692, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGHPDBH3TLWE2M7UIMIALSRWMBNANCNFSM4SDZEWEA
.
marcospassos
on 26 Nov 2020
hi! Sorry my brain can't handle submodules ;)
beast:master:~/antlr/code/antlr4 $ cd runtime
beast:master:~/antlr/code/antlr4/runtime $ cd PHP
(reverse-i-search)`pull': git pull origin master
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ https://github.com/parrt/tensor-sensor/issues/16
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git submodule update --recursive
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git submodule update --remote --merge # might only need this last one but do both
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ grep 4.8 src/RuntimeMetaData.php
public const VERSION = '4.8';
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $
On Wed, Nov 25, 2020 at 21:06 Terence Parr notifications@github.com wrote:
hi! Sorry my brain can't handle submodules ;)
beast:master:~/antlr/code/antlr4 $ cd runtime
beast:master:~/antlr/code/antlr4/runtime $ cd PHP
(reverse-i-search)`pull': git pull origin master
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ https://github.com/parrt/tensor-sensor/issues/16
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git submodule update --recursive
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git submodule update --remote --merge # might only need this last one but do both
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ grep 4.8 src/RuntimeMetaData.php
public const VERSION = '4.8';beast:master⤓:~/antlr/code/antlr4/runtime/PHP $
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/antlr/antlr4/issues/2932#issuecomment-734015815, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGHPFLBSULXQEGFP5HU33SRWSZDANCNFSM4SDZEWEA
.
marcospassos
on 26 Nov 2020
I did a pull and i get it:
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git pull origin master
From https://github.com/antlr/antlr-php-runtime
* branch master -> FETCH_HEAD
Updating 62fd3c3..c84f4b0
Fast-forward
src/RuntimeMetaData.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Up in main repo, do i need a commit again?
beast:master:~/antlr/code/antlr4 $ git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
(commit or discard the untracked or modified content in submodules)
modified: runtime/PHP (new commits, untracked content)
...
Hmm...same problem:
beast:master:~/antlr/code/antlr4 $ git commit -a -m "Update PHP Runtime to latest version"
[master 479091306] Update PHP Runtime to latest version
1 file changed, 1 insertion(+), 1 deletion(-)
beast:master⤒:~/antlr/code/antlr4 $ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
(commit or discard the untracked or modified content in submodules)
modified: runtime/PHP (untracked content)
Yep, you’ve to commit the submodule update
On Wed, Nov 25, 2020 at 21:11 Terence Parr notifications@github.com wrote:
I did a pull and i get it:
beast:master⤓:~/antlr/code/antlr4/runtime/PHP $ git pull origin master
From https://github.com/antlr/antlr-php-runtime
- branch master -> FETCH_HEAD
Updating 62fd3c3..c84f4b0
Fast-forward
src/RuntimeMetaData.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Up in main repo, do i need a commit again?
beast:master:~/antlr/code/antlr4 $ git status
On branch master
Your branch is up to date with 'origin/master'.
Changes not staged for commit:
(use "git add
..." to update what will be committed) (use "git restore
..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules)
modified: runtime/PHP (new commits, untracked content)
...
Hmm...same problem:
beast:master:~/antlr/code/antlr4 $ git commit -a -m "Update PHP Runtime to latest version"
[master 479091306] Update PHP Runtime to latest version
1 file changed, 1 insertion(+), 1 deletion(-)
beast:master⤒:~/antlr/code/antlr4 $ git status
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)
Changes not staged for commit:
(use "git add
..." to update what will be committed) (use "git restore
..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules)
modified: runtime/PHP (untracked content)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/antlr/antlr4/issues/2932#issuecomment-734017156, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHGHPE6XPMHDVLIYRAJPK3SRWTNBANCNFSM4SDZEWEA
.
marcospassos
on 26 Nov 2020
Status is clean in runtime/PHP though. Main repo is not clean.
I add runtime/PHP and then commit. still unclean:
modified: runtime/PHP (untracked content)
we had trouble last release too. beginning to think cp -r is our friend here.
parrt
on 26 Nov 2020
Hi,
yes works for me.
Eric
Le 26 nov. 2020 Ă 08:08, Terence Parr notifications@github.com a Ă©crit :
@ericvergnaud https://github.com/ericvergnaud does this package look right?
Antlr4.Runtime.Standard.4.9.0.nupkg.zip https://github.com/antlr/antlr4/files/5599734/Antlr4.Runtime.Standard.4.9.0.nupkg.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/antlr/antlr4/issues/2932#issuecomment-734000692, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZNQJHBUARF627AKP7OVRDSRWMBNANCNFSM4SDZEWEA.
ericvergnaud
on 26 Nov 2020
Ok, thanks to @marcospassos I now have the PHP thing updating properly using a fresh clone. this now says 4.9: https://github.com/antlr/antlr-php-runtime/blob/c84f4b077b1ecf17a6465c6a442c370597578325/src/RuntimeMetaData.php#L54
Ooook. so now I think I need to cut a 4.9 release branch emanating directly from when maven reset the number. Then get appveyor to kick off a build for that and then use that for nukpkg.
parrt
on 26 Nov 2020
ok, I think i updated nupkg correctly, @ericvergnaud! https://www.nuget.org/packages/Antlr4.Runtime.Standard/4.9.0
I guess i'm done again for awhile :)
parrt
on 26 Nov 2020
Related issues
KevinGossentCap
·
14Comments
parrt
·
27Comments
anidotnet
·
55Comments
parrt
·
84Comments
ngundu
·
18Comments
Most helpful comment
Ok gang. @pboyer, @mike-lischke, @janyou, @ewanmellor, @hanjoes, @ericvergnaud, @lingyv-li, @marcospassos @davesisson I think next week during the US Thanksgiving holiday I will try to push out 4.9. thanks for all your efforts.