Antennapod: [Statistics] Add count of episodes stocked on device

Created on 21 Oct 2020  路  8Comments  路  Source: AntennaPod/AntennaPod

Checklist

  • [x] I have used the search function to see if someone else has already submitted the same feature request.
  • [x] I will only create one feature request per issue.
  • [x] I will describe the problem with as much detail as possible.

App version / source: 2.0.1 / Google Play

Feature description

In statistics screen there is a tab about episodes stocked on device. It informs on how much space is used.
Additionally it would be a good idea to add how many episodes are stocked.

Below a mockup to express what I mean :

9eo3nepg
:

(splitted from issue #4552)

enhancement good first issue hacktoberfest

All 8 comments

Can i work on this ?

Sure, go ahead :)

Just to note: let's keep the text the same colour as the MB indication, and let's use a middle dot ( 路 ) for a separator as it's also used elsewhere in the interface :)

@keunes Okay thank you!

@ByteHamster @keunes Are the changes right? If yes, can you help me out with the PR. This is my first PR, it would be really helpful if you could help me.

Changes made :
1) Added a counter to DBReader to count the number of episodes downloaded.
2) Added the counter to StatisticsItem.
3) Added a TextView in Statistic List Item.
4) Used the counter to display the number of episodes downloaded.

Also I had one doubt, what about the translations of the "episode" and "No episode downloaded" string ? Do I need to add them in core ?

WhatsApp Image 2020-10-22 at 13 33 34

I don't know about code, but in terms of visuals, I would make two changes:

  • use the 'middle dot' (probably the wrong term) between the two elements, instead of a simple period (you can check the queue screen - it's between the date and the MB indication)
  • I would not make it italic (cursive) - it's attracting a bit too much attention

Then I just thought: I guess you planned this already, but please make sure it's translatable. In terms of strings I think it should be "x episode" (1) / "x episodes" (2+) / "no episodes" (0) - but please bear in mind that more/different forms are needed in other languages. Mozilla has a nice overview all possible plurals in many different languages. Don't know how this should be considered in code, though.

@keunes Thanks for the help, I'll make the changes you mentioned.

I have made a PR :) Thanks

Was this page helpful?
0 / 5 - 0 ratings

Related issues

keunes picture keunes  路  4Comments

fabolhak picture fabolhak  路  3Comments

yosefmizrahi picture yosefmizrahi  路  3Comments

ggshuini picture ggshuini  路  4Comments

Rotzbua picture Rotzbua  路  4Comments