Anki-android: Incorrect v2 scheduler intervals - possible errors found, can somebody confirm?

[danosl]

Reproduction Steps

1. Current settings:
2. New cards: Graduating interval - 1 day, Easy interval - 2 days, Starting ease 200%

3. Reviews: Easy bonus - 120%, Interval modifier - 150%

4. Doing regular daily repetitions.

Expected Result

New: Again: 2 min; Hard: 6 min; Good: 1 d; Easy: 2 d

Learning: Again: 10 min; Hard: 15 min; Good: 5 d; Easy: 6 d
Learning: Again: 10 min; Hard: 15 min; Good: 6 d; Easy: 8 d

Reviews: Again: 10 min; Hard: 3 d; Good: 5 d, Easy: 6 d
Reviews: Again: 10 min; Hard: 1.1 mo; Good: 1.7 mo, Easy: 2 mo

Actual Result

New: Again: 2 min; Hard: 6 min; Good: 10 min; Easy 2 d

Learning: Again: 10 min; Hard: 15 min; Good: 5 d; Easy: 5 d
Learning: Again: 10 min; Hard: 15 min; Good: 6 d; Easy: 6 d

Reviews: Again: 10 min; Hard: 3 d; Good: 3.7 mo, Easy: 8.7 mo
Reviews: Again: 10 min; Hard: 1.1 mo; Good: 4.9 mo, Easy: 10.1 mo

(but then _sometimes_: Learning: Again: 10 min; Hard: 15 min; Good: 1 d; Easy 2 d)

Debug info

AnkiDroid Version = 2.10alpha5 (same issues on 2.9.2beta2)
Android Version = 9
ACRA UUID = 487213d0-406b-466f-9e94-12da9cf75cf0

Research

Enter an [ x ] character to confirm the points below:

[ x ] I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid

[ x ] I have checked the manual and the FAQ and could not find a solution to my issue

[ x ] I have searched for similar existing issues here and on the user forum

[timrae]

Can you provide a sample deck for reproduction?

On Tue., 22 Oct. 2019, 10:39 am danosl, [e-mail] wrote:

Reproduction Steps

1. Current settings: Reviews: Easy bonus - 120%, Interval modifier -
   150%
2. Doing regular daily repetitions.

Expected Result

New: Again: 2 min; Hard: 6 min; Good: 1 d; Easy: 2 d

Learning: Again: 10 min; Hard: 15 min; Good: 5 d; Easy: 6 d
Learning: Again: 10 min; Hard: 15 min; Good: 6 d; Easy: 8 d

Reviews: Again: 10 min; Hard: 3 d; Good: 5 d, Easy: 6 d
Reviews: Again: 10 min; Hard: 1.1 mo; Good: 1.7 mo, Easy: 2 mo
Actual Result

New: Again: 2 min; Hard: 6 min; Good: 10 min; Easy 2 d

Learning: Again: 10 min; Hard: 15 min; Good: 5 d; Easy: 5 d
Learning: Again: 10 min; Hard: 15 min; Good: 6 d; Easy: 6 d

Reviews: Again: 10 min; Hard: 3 d; Good: 3.7 mo, Easy: 8.7 mo
Reviews: Again: 10 min; Hard: 1.1 mo; Good: 4.9 mo, Easy: 10.1 mo

but then sometimes:
Learning: Again: 10 min; Hard: 15 min; Good: 1 d; Easy 2 d
Debug info

AnkiDroid Version = 2.10alpha5 (same issues on 2.9.2beta2)
Android Version = 9
ACRA UUID = 487213d0-406b-466f-9e94-12da9cf75cf0
Research

Enter an [ x ] character to confirm the points below:

[ x ] I have read the support page https://ankidroid.org/docs/help.html
and am reporting a bug or enhancement request specific to AnkiDroid

[ x ] I have checked the manual https://ankidroid.org/docs/manual.html
and the FAQ https://github.com/ankidroid/Anki-Android/wiki/FAQ and
could not find a solution to my issue

[ x ] I have searched for similar existing issues here and on the user
forum

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ankidroid/Anki-Android/issues/5558?email_source=notifications&email_token=AAVQBYS3PO34ZQ3KSAO4373QPZKWXA5CNFSM4JDJN4LKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTL2ZFQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVQBYSNT3MTHBV63PQJBXDQPZKWXANCNFSM4JDJN4LA
.

[danosl]

Can you provide a sample deck for reproduction?

Sure, how do I do it? I'm new here.

[timrae]

If you don't mind sharing publicly you can post a Google drive link here.

On Tue., 22 Oct. 2019, 10:47 am danosl, [e-mail] wrote:

Can you provide a sample deck for reproduction?

Sure, how do I do it? I'm new here.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ankidroid/Anki-Android/issues/5558?email_source=notifications&email_token=AAVQBYRD7RJVPZC7MQ7DQX3QPZLTJA5CNFSM4JDJN4LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4J5QI#issuecomment-544775873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVQBYU2745KOQUXOXKJWOLQPZLTJANCNFSM4JDJN4LA
.

[danosl]

If you don't mind sharing publicly you can post a Google drive link here.

Here you go: AnkiDroid collection.colpkg

…
On Tue., 22 Oct. 2019, 10:47 am danosl, @.*> wrote: Can you provide a sample deck for reproduction? Sure, how do I do it? I'm new here. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5558?email_source=notifications&email_token=AAVQBYRD7RJVPZC7MQ7DQX3QPZLTJA5CNFSM4JDJN4LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEB4J5QI#issuecomment-544775873>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVQBYU2745KOQUXOXKJWOLQPZLTJANCNFSM4JDJN4LA .

[Mornon]

Not sure if it's related: https://github.com/ankidroid/Anki-Android/issues/5449

[danosl]

Not sure if it's related: #5449

Thanks for your feedback! I doubt these are related, though.

IMHO, they rather seem like two separate issues.

Have you had a chance to look into this, @timrae ? Sorry for nagging, but I'm completety stuck with _Hard_ during my reviews, even though other options would have been much more appropriate.

[danosl]

I think I may have found the problem in SchedV2.java where the intervals seem to be calculated.

IMHO, 86400 at the following three locations should be replaced by 86400L
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L2181
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L2183
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L2205

Just as it is at these two locations below (which is also consistent with Sched.java):
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L2176
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L2210

@ChrisPWill & @hssm Could you guys confirm that, please? Thanks!

[mikehardy]

Tagging in @Arthur-Milchior (currently doing a pile of anki -> ankidroid porting) and @hssm (implemented v2 scheduler here)

[danosl]

Thanks! There might be yet another spot that needs correction (not 100% sure about this one):
https://github.com/ankidroid/Anki-Android/blob/00b67f5b67519de705d9de480b2973f9c42bcbe6/AnkiDroid/src/main/java/com/ichi2/libanki/SchedV2.java#L1995

[danosl]

Pull request created: https://github.com/ankidroid/Anki-Android/pull/5574

[Mornon]

Thanks! At the moment I don't think i'm using the v2 scheduler (I wanted to check about the differences and if it supports time zones without changing the starting time of the day, then I kinda forgot about it), the relevant checkbox is unchecked.