Angular-google-maps: Errors after upgrade

Created on 21 Nov 2019  路  7Comments  路  Source: SebastianM/angular-google-maps

I am receiving the errors

4538:120-128 "export '傻傻inject' was not found in '@angular/core'

4538:34-52 "export '傻傻defineInjectable' was not found in '@angular/core'

after upgrading to version 1.1.0 from 1.0.0-beta.5

Most helpful comment

So I think the issue is this is a breaking change for Angular 7 projects. For example, in our package.json, we have the following:

"@agm/core": "^1.0.0-beta.5"

On a fresh npm install, this silently updated, I believe to 1.1.0 and breaks. According to npm, 1.1.0 is a minor, backwards compatible change. However, in this case it is not actually backwards compatible.

All 7 comments

1.1.0 is compatible only with angular 8.0+

So I think the issue is this is a breaking change for Angular 7 projects. For example, in our package.json, we have the following:

"@agm/core": "^1.0.0-beta.5"

On a fresh npm install, this silently updated, I believe to 1.1.0 and breaks. According to npm, 1.1.0 is a minor, backwards compatible change. However, in this case it is not actually backwards compatible.

Correct, we didn't expect this regression.

So for anyone using 1.0.0-beta.5/6/7 with Angular 7 and suddenly started seeing "傻傻defineInjectable" on deployment esp on production, a workaround for now would be to remove the '^' sign from the @agm/core package in package.json to install the exact version instead of the latest one (which is not backwards compatible).

use 1.0.0 without ^ sign

.... what about people not knowing about this?
Shouldn't a warning be added in documentation or during package installation?

use 1.0.0 without ^ sign

I'd rather set ~1.0.0

Was this page helpful?
0 / 5 - 0 ratings