Angular-google-maps: update angular2 dependency to rc

Created on 9 May 2016  路  12Comments  路  Source: SebastianM/angular-google-maps

critical feature-request

Most helpful comment

@carl09 thanks! I will review your PR this evening

All 12 comments

+1

+1

+1

Hi

I just updated the code to use angular rc1, but when i did a pull request i for a tslint error, when i run it localy i did not get any issues, i can run gulp build and gulp test and they both run.

i am running on windows 10 and i am really new with npm gulp and all this process, i have had a look around and can't find any reasons why tslint runs differnt.

could some body help me out? i think it is todo with clang-format and .clang-format

https://github.com/SebastianM/angular2-google-maps/pull/339

Thanks

got it sorted, but still do not know why my clang-format results where different then the server.

I have made a quick example to see if it works, https://github.com/carl09/angular2-google-maps-example

any feedback would great
Thanks

@carl09 thanks! I will review your PR this evening

@carl09
Tried upgrading it myself but i kept getting weird clang-format errors so i gave up at 3am^^

For me RC1 worked but I have a problem with RXJS

ISSUE: 338

@carl09 added some comments. if you can address these things, we can merge it and release a new version

Thx @SebastianM

@fdu-axiometrics v0.10.0 just released with angular rc1 support - thanks to @carl09

I also updated the plunker: http://plnkr.co/edit/YX7W20?p=preview

// cc @brian-singer @siegerx3 @telran @arno87

nice work! Thank you guys!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shedar picture shedar  路  4Comments

alexweber picture alexweber  路  4Comments

nthonymiller picture nthonymiller  路  4Comments

gnujeremie picture gnujeremie  路  3Comments

dineshkumar20 picture dineshkumar20  路  3Comments