Angular-cli: ng generate add imports for generated .spec tests

[zzj0402]

Relevant Package

@angular/cli

Description

generate schematics doesn't import/declare components for .spec test files.

Describe the solution you'd like

Add scripts to scan and add import/declaration in the file.

Describe alternatives you've considered

Manual addition.

[AndrewKushnir]

Hi @zzj0402, could you please provide a bit more information (may be also including simple examples) on this issue? Thank you.

[SahilShikalgar]

The issue is like whenever we used to do ng generate component or ng generate service in the current version it doesn't add dependencies in spec.ts [Testing File].

[AndrewKushnir]

Thanks for additional information @SahilShikalgar. I'm transferring this ticket to Angular CLI repo, since it's CLI-related. Thank you.

[alan-agius4]

Hi @SahilShikalgar and @zzj0402 we are not understanding the issue.

Can you please provide clear description of the current and expected behaviour?

[zzj0402]

Which part of the description you don't understand?

[alan-agius4]

Which dependencies do you expect to be adding in .spec.ts? Can you please provide a snippet of the incorrect code and a snippet of the expected code.

Also, kindly provide the output of ng version

Thanks.

[zzj0402]

I expect dependencies in app.modules.ts file imported to all test files. So that I don't have to do copy and paste module imports for each .spec file created.

[zzj0402]

Not by computer at moment.

[SahilShikalgar]

Suppose my app.component.html have the following code

<div>
   <app-header></app-header>
   <app-body></app-body>
   <app-footer></app-footer>
  <div class="dropdown" ngbCollapse>
</div>

Here I'm adding using 3 child components into this. Here in spec.ts file, the declarations should be added into spec.ts automatically as we use it in HTML [using quick fix of VS Code].

In the above example in spec.ts file we need
declaration: [ HeaderComponent, FooterComponent, BodyComponent ],
imports: [ NgbBootstrap ]

In the current scenario, we manually need to add all the dependencies so we can make it automatic if possible.

[alan-agius4]

Hi all, thanks for opening this feature request. However we are very cautious what features we include in the CLI as any new features will need to be given proper support. At the moment the requested feature doesn't fit in the scope of the CLI.

Thanks for your understanding and for using Angular CLI.

[zzj0402]

@alan-agius4 What is the scope you are talking about? Automatic importing doesn't fit CLI "scope"?

[zzj0402]

Which dependencies do you expect to be adding in .spec.ts? Can you please provide a snippet of the incorrect code and a snippet of the expected code.

Also, kindly provide the output of ng version

Thanks.

This is a feature request. There is nothing "incorrect".

[alan-agius4]

Hi @zzj0402,

By "scope", I mean features that the tooling team wants to develop, support and maintain. Since every feature that is developed will require support and maintenance we are very cautions in which features to include.

Currently, the feature you are requesting doesn't fall in this scope.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}