Angular-cli: Deprecate styles and script `lazy` option in favor of a more self descriptive option

Created on 18 Jun 2019  路  4Comments  路  Source: angular/angular-cli

馃殌 Feature request

Description

The lazy option inside the script and style option is confusing as this option doesn't lazy load a bundle but rather it doesn't inject/reference the script in the HTML. While this option is an enabler for lazy loading, the users will still need to handle on how how this bundle will be lazy loaded. There are also potential use cases beyond lazy loading for the option.

Deprecate the lazy option in favour of a more self descriptive options such as injected.

devkibuild-angular feature

Most helpful comment

Deprecation+migration on 9 SGTM. I have no opinion on inject vs injected, I guess it's a consistency thing.

Looking at extractCss and extractLicenses it sounds like it should be inject. But then we have optimization that makes me think injected would be better. So maybe we just need to decide what tense we want for options and stick to it.

All 4 comments

@filipesilva any thoughts about the above? We discussed this in our meeting and myself, @mgechev and @clydin all think it's best to deprecate lazy.

We didn't yet decide the name of the new option though, May it can be inject or injected?

Deprecation+migration on 9 SGTM. I have no opinion on inject vs injected, I guess it's a consistency thing.

Looking at extractCss and extractLicenses it sounds like it should be inject. But then we have optimization that makes me think injected would be better. So maybe we just need to decide what tense we want for options and stick to it.

Discussed and decided on inject.

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_This action has been performed automatically by a bot._

Was this page helpful?
0 / 5 - 0 ratings