Angular-cli: ng test should accept customized config parameter of karma.config.js

Created on 19 Sep 2018  路  5Comments  路  Source: angular/angular-cli

Bug Report or Feature Request (mark with an x)

- [x] feature request

Command (mark with an x)

- [x] test

Versions

node v8.10.0
npm 5.6.0
@angular/cli 6.1.3

Repro steps

After upgrade to angular 6, the parameter set for the config of karma.config.js does not work anymore
it's NOT the parameter to specify which file, our script is like this

npm run test -- --customizedParam=paramValue

In the karma.config.js, the parameter is used.
module.exports = function (config) {
var customizedParam= config.customizedParam;
......
}

the npm run test is ng test in package.json
this parameter value is decided in build agent, and everytime is different.

The log given by the failure

Unknown option: '--customizedParam'
and it stopped the test run

Desired functionality

the command line parameters for karma config can be accepted as before
or a workaround.
angular 5 cli will also prompt warning message but it didn't stop test and the parameter take effect.

Mention any other details that might be useful

devkibuild-angular low inconvenient triage #1 feature

Most helpful comment

I need this too - should allow a --customFlag

All 5 comments

Hi @datanglibai ,

Thanks for the request. We stopped accepting invalid options after 6.0 (deliberately), and this was a known breaking change. I don't think we want to allow custom flags to be passed to karma, but I'll keep this as a feature request.

Thanks!

Hello @hansl

I search in documentation, issues and stack overflow but can't find any solution to launch tests from single spec file (fdescribe is not an option) in angular 6+ applications.

In previous versions we use this solution, but for now all unknown --flags are disabled.

You removed this feature, but not offered alternative way. I understand why you block all unknown flags, this is right solution. But also you can add just one more allowed flag (let's say --spec) and this will help to other developers.

What is status of this? Every time i figure out a way to test a single component, a few months later it breaks.

@chiantia I don't know whether the angular team will solve this issue. For now i write a fast fix for this

I need this too - should allow a --customFlag

Was this page helpful?
0 / 5 - 0 ratings