Angular-cli: Empty string as base href argument

[williamAlhant]

Bug Report or Feature Request (mark with an x)

- [X] bug report -> please search issues before submitting
- [ ] feature request

Versions.

1.0.3
(I checked the change log for newer versions but there is no reference to this particular issue, as far as I can see)

Repro steps.

When using the --base-href argument, it does not seem to be possible to use an empty string, as it keeps the old base href (the one set in index.html) instead of overriding it with empty string.

I am using the following command :
ng build --watch --output-hashing=none --base-href='' --output-path=[...]
but the base-href is not working as intended.

[filipesilva]

This is a bug in https://github.com/angular/angular-cli/blob/master/packages/@angular/cli/lib/base-href-webpack/base-href-webpack-plugin.ts#L10.

We do if (!this.options.baseHref) { and since !'' is also evaluated to false, the plugin does nothing.

Would you be interested in making a PR that fixes this behaviour?

[sendilkumarn]

@filipesilva is this up for grab?

[filipesilva]

Sure is!

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{_This action has been performed automatically by a bot._}