Angular-cli: Lots of Copyright comment blocks in main.js build

Created on 28 Sep 2016 · 8Comments · Source: angular/angular-cli

Version: beta.16
OS: OSX 10.12

So I just ran an ng build -prod --aot using beta.16 and was looking at the output. I noticed main.js has about 20 - 30 instances of Google Copyright notice (one above each block). The same happens for a build without AoT as well actually.

/**
 * @license
 * Copyright Google Inc. All Rights Reserved.
 *
 * Use of this source code is governed by an MIT-style license that can be
 * found in the LICENSE file at https://angular.io/license
 */

I'm guessing there should only really be one or none of those at the top of the generated dist/main.js

Screenshot: https://www.dropbox.com/s/4cuf1yxtik9drjy/Screenshot%202016-09-28%2010.50.09.png?dl=0

1 (urgent) bufix

Source

intellix

👍7

All 8 comments

@hansl can you have a look? This must be part of the total bundle size.

filipesilva on 28 Sep 2016

I need to talk to the legal team about this. The google ones are probably okay to only put one, but third party libraries might be more complicated.

hansl on 28 Sep 2016

Just FYI I made a new beta16 project and ran the main bundle through a comment stripper, and non-gzipped size went from 815kb to 764kb.

bonnici on 29 Sep 2016

👍1

Speaking of comments.

I'm using material-design-lite and building it from scss. My styles.bundle.js with --prod contains 31 occurrences of every single /* */ comment (not // comments) in _variables.scss as it's included 31 times.

Perhaps I should create a separate issue for this tho?

grizzm0 on 29 Sep 2016

👍1

CSS comments has been solved in #2593.

grizzm0 on 17 Oct 2016

I see the comments with builds using ngCLI beta.17 as well. Can we strip the credits into a credits.txt file that refers to the compiled _.js/_.css? MIT doesn't require the presence of the copyright notice in binary distributions. Can a *.js file be considered a binary distribution?