Angular-auth-oidc-client: LogLevel has only 3 level. but cannot disable it in version 11?

[hmheng]

Describe the bug
LogLevel has only 3 level. but cannot disable it in version 11?

Expected behavior
Add disable enum

[joffarex]

It is optional parameter, you can just not pass it at all so you will not get any logging.

[hmheng]

I would have to remove the parameter entirely in the app.module.
Should we add LogLevel.none to disable it instead so that we don't touch the code in the app.module?

This will be helpful if we would want to debug on dev environment without pushing another changes to the code just to turn on/off the logging.

[joffarex]

Well, as of now, you could extract config object and do an property attaching depending on your environment.

[hmheng]

yeap, sure. thank you @joffarex

[FabianGosebrink]

Is the PR helping you?

[hmheng]

@FabianGosebrink seems good to me! Thank you.
Just one question more for the PR, logLevel in configAuth() is default to none if environment is production right?

[FabianGosebrink]

We do not take the switch if you are running in production or not. Therefore we have to enhance the config for that. So the default would be fix for env and dev in this case. Default is Warn if nothing is given.

https://github.com/damienbod/angular-auth-oidc-client/blob/master/projects/angular-auth-oidc-client/src/lib/config/default-config.ts#L25

[damienbod]

fixed, will be released in the next version