Angular-auth-oidc-client: Question - v1.3.4, anyone seen this?

[RowSolAdmin]

Have run 1.3.1 / 1.3.2 / 1.3.3 without issue. Went to latest version 1.3.4 and get the error shown in screen dump.

Looking at the code it appears the createAuthorizeUrl is making a call

var /** @type {?} */ customParams =
this.oidcSecurityCommon.retrieve(this.oidcSecurityCommon.storage_custom_request_params);
Object.keys(customParams).forEach(function (key) {
params.set(key, customParams[key]);
});

The 'customParams' object is null hence causing the issue I am seeing locally.

I have tried creating a new app from scratch using the quick start tutorial and still see this problem.

Thoughts?
Thanks!

[vicver82]

I'm also getting an error with 1.3.4. I reverted back to 1.3.2 to keep working on my project. I'll post the error output here at the earliest opportunity.

[damienbod]

looks like 1.3.4 has a bug here. Use 1.3.3 and I'll fix today. Sorry

@pieman302 @vicver82 Thanks for reporting.

Greetings Damien

[damienbod]

@pieman302 @vicver82 @HWouters Reverted this and added tests, Version 1.3.5 must work again

[damienbod]

@robisim74 The tests run local, but fail on the server, any ideas?

https://travis-ci.org/damienbod/angular-auth-oidc-client/builds/263122531

[robisim74]

Are you calling an external url inside the test?

[damienbod]

Yes, I can remove this, thanks

[robisim74]

Maybe there is a way, but it is not simple: https://assertible.com/blog/how-to-run-api-integration-tests-on-ci

Usually it is better to create a mock backend or a mock service.

[RowSolAdmin]

Thanks guys, appreciated :-)

[damienbod]

fixed in version 1.3.5