AndroidPdfViewer 3.0.0-beta - bug reports & feature improvements

[barteksc]

Today version 3.0.0-beta.1 was released, which has support for different page sizes, links and 3 modes of fitting document to screen.

Please report bugs and improvements for added features.
Please do not request new features, as current target is to release stable 3.0.0.

[1stmetro]

Could we do away with background color being used as the page border..... i hve to modify the code on every update...

Will load up beta shortly.

[barteksc]

Pages don't have borders. If you talk about spacing, the spacing is gap, and through the gap you see what is behind the document.

[1stmetro]

Yeah the spacing.

I have to mod source to draw the space as sometimes a large pdf will leave a coloured page and also the scroll in from the right pdf shows a coloured page sliding into view etc.

[1stmetro]

Side swipe in landscape view i have a large white space on the right side, anyone else have the same issue ?

It appears to believe my page size is the width of the device, hence the white gap on the page.

[barteksc]

@1stmetro Please post your code, screenshot and PDF document if possible.

[albakaly]

Beside page border issue.
Zoom in is not work if I get full zoom. The pdf blurred and never cleared unless I zoom out.

[1stmetro]

I can confirm the issues with max zoom is correct it does'nt do a final render.

Any pdf i use in this mode gives me the white gap but you can see page 2 coming into view

Also notice the page number object floats down.

[barteksc]

@1stmetro please post you code

[1stmetro]

Okay if i change the policy to .pageFitPolicy(FitPolicy.HEIGHT) then i get the following as shown, the screen is in landscape, no code changes just changing the policy when loading a normal pdf.

[barteksc]

@1stmetro You are using horizontal swipe and scroll handle is in position like in vertical mode?

[1stmetro]

Horizontal swipe in portrait or landscape i get the gap in height policy its better but the policy appears to be static as it doesn't change when changing orientation i'm sure you get what i mean now.

Also the maximum zoom does not final render,

[1stmetro]

albakaly if its an activity issue that you cant go back to that would'nt be a pdf view issue.

[barteksc]

@1stmetro I cannot reproduce this behavior, could you send PDF document?

[albakaly]

I think it is as you said problem with activity shared elements not from the library.

Thanks

[1stmetro]

Currently disabled that type of view, it used to work fine but not anymore.

Basically it would resize on height and not width and allow a smaller page view that can be swiped sideways. This view would allow the user to quickly find a page and then return to the view to full width view.

LiIon_tut.pdf

Any pdf's seem to do the same after changing to horizontal swipes using code below,

if (pdfView.isSwipeVertical()) {
pdfView.setSwipeVertical(false);
pdfView.jumpTo(pdfView.getCurrentPage());
pdfView.resetZoom();

        }
        else{
            pdfView.setSwipeVertical(true);
            pdfView.jumpTo(pdfView.getCurrentPage());
            pdfView.resetZoom();
        }

[barteksc]

@1stmetro So the problem is that you are changing swipe to horizontal after loading document. I forgot to make setSwipeVertical() private. It requires to much calculations to use this method. Swipe mode must be set using .swipeHorizontal() when loading document.

[1stmetro]

Okay so you cannot change the swipe after the document has been loaded?

[albakaly]

@barteksc have you into the zoom issue?

[barteksc]

@1stmetro You cannot. It shouldn't be possible either in 2.X versions, but it is my mistake.
@albakaly I reproduced this issue, so it will be fixed in next release

[barteksc]

Beta 3.0.0-beta.2 released with zoom fixes.

[1stmetro]

just upgraded to beta 2 i see you fixed my loop hole issue....

Now i will have to write a fix to show mini pages....

[albakaly]

@barteksc Thank you so much.
Zooming is great .

[barteksc]

@1stmetro what is loop hole issue?

[1stmetro]

the if (pdfView.isSwipeVertical()) it is now private.

tell how do you get the total width and height of the whole canvas ?

dstRect.right
dstRect.bottom

[barteksc]

.isSwipeVertical() is public, not private.
PdfFile#getDocLen() gives you current document length (height in vertical mode, width in horizontal) and PdfFile#getMaxPageSize() gives you size of page with maximum width (in vertical mode) or maximum height (in horizontal mode)

[barteksc]

Version 3.0.0-beta.3 released with fixed bug preventing OnErrorListener from being called.

[1stmetro]

Getting it now, Thanks ! Works perfect for me!

[1stmetro]

Maybe worth closing this one and reopen a 3.0.0-beta 3

I have an issue with i believe different page sizes, if offsets from the left side so the page is not fitting to width.

This pdf 's contain just about every page size, you will see what i mean by left border.
pagesizes.pdf

PageSizes_output.pdf

[barteksc]

@1stmetro I've opened both documents and don't understand where is the issue

[1stmetro]

maybe not a good example, this image left side pic shows the border i mean but if i drag from right to left i then you see whole page, whole pdf is the same.

[barteksc]

@1stmetro What does it mean "whole pdf is the same"?

[1stmetro]

I will look at the spec of the pdf but for some reason it offsets this pdf and doesn't resize correctly.

[barteksc]

@1stmetro Currently I don't understand anything from your bug report

[albakaly]

I noticed that when I scroll between pages , something like flashes appears. Example, I have two pages when I scroll from the first page to second , the second page jumps to the screen like flash, like it blurred, however I was reading in the half of the first page .
In brief, scrolling is not soomth between pages, when you scroll to half of the first page the second page jumps to screen like flash or blurred. So when you are reading at the mid of any page , the next page jump to the screen and you just feel like you lost and return to the previous page. It is really tiring.
Sorry if you don't understand my point.

[starnaus]

Is there a setting to show/swipe one page at a time? Centered in the view?

[barteksc]

@starnaus no, there is no such possibility

[starnaus]

Thank you for the reply. Is this feature on a roadmap for a future version?

[1stmetro]

Download the source @starnaus and modify to how you want it to work that's what others do.

[KewalMedic]

Unable to open Hyperlinks within pdf:

I am using version 3.0.0-beta.3 and below is the code to load pdf-
_pdfView.fromFile(new File(filePath))
.defaultPage(0)
.scrollHandle(new DefaultScrollHandle(this))
.pageFitPolicy(FitPolicy.BOTH)
.spacing(10)
.enableAnnotationRendering(true)
.linkHandler(new DefaultLinkHandler(pdfView))
.onError(this)
.load();_

This the same code to load pdf as written in sample app too but its not working for hyperlinks.
Looking for the solution.

Thanks,

[Jiten-Medic]

Hi @barteksc

We're using this library and having some major issues while URL link clicks.
No callback was fired when we click over the URL where as Dropbox and other PDF viewers opens the link of same PDF.

Lib Details :
version 3.0.0-beta.3

Same code as mentioned by @KewalMedic is used, please help to resolve this bug.

Below attached is the sample pdf file used for the testing.
Get Started with Dropbox.pdf

Thanks

[Jiten-Medic]

Hi @barteksc
Have you found the reason for links not working, any timeline for the same.

Thanks

[barteksc]

@Jiten-Medic links should be fixed in 3.0.0-beta.5 version

[1stmetro]

Thanks @barteksc now got beta 5 and working fine,

[Jiten-Medic]

Hi @barteksc

Thanks for your update, it's working fine for hyperlinks.
But when the URL is written like text as https://google.com it doesn't takes the click and not open them.

Please look over this as well.

Regards

[barteksc]

@Jiten-Medic only links are clickable, there is no mechanism for detecting plaintext URLs

[devi2911]

I have a pdf thats 106 MB and has got 100 pages....The PDF is viewed only for the first 5 or 6 pages and then it ends @barteksc Please help

[1stmetro]

Can you post the pdf so I can check it?

[devi2911]

@1stmetro sorry to have bothered you....It's working fine...silly mistake in code...cheers

[1stmetro]

No probs...

[chiragc-wal]

@barteksc Hyperlinks are not working in 3.1.0-beta.1
Below is my code,

pdfView.fromFile(file)
.enableAnnotationRendering(true)
.onLoad(this)
.scrollHandle(new DefaultScrollHandle(this))
.spacing(10) // in dp
.onPageError(this)
.linkHandler(new DefaultLinkHandler(pdfView)) // It's a default handler of library
.load();

[kuerm]

@barteksc As I wrote in https://github.com/barteksc/AndroidPdfViewer/issues/674, there's still an error in jumpTo (I don't know if you get updates on closed issue.. )
I guess that if the first page has an Offset != 0, then the next ones won't be displayed correctly. I attached a sample file.
Maybe the best solution would be to set offset to 0 when loading pdf, to not have strange behaviour later in PDF management.
offsetgreater0.pdf
(this PDF was created by musescore.org App