Android: Favicons get swapped!

[oldphones68]

Describe the bug
Favicons get swapped.
This seems close to the issue #975.

How to Reproduce
Steps to reproduce the behavior:

1. Go to 'Bookmarks'
2. See error

Although in #975 seeming @aitorvs has provided a patch, but I'm seeing this bug is still existing.

Expected behavior
Favicons should show correctly.

Smartphone

• DDG App Version: 5.80.0
• OS: Android 6

[Ammako]

Yup. Mine shows github with a reddit favicon.

[cmonfortep]

Could you provide more info like: how many bookmarks you have? does it happen right after opening the screen or when scrolling? Do you see the same error on the tabs screen or only in the bookmarks screen?

[Ammako]

4 bookmarks

Right when opening the screen

Only bookmarks screen

[cmonfortep]

Thanks. That's weird, we use the same class to retrieve bookmark icon in the bookmarks screen and the tab screen (the one where you see all your tabs).

We will investigate what's happening there

[oldphones68]

18 bookmarks so far.

It happens after opening the browser.

Happens on the bookmarks menu. Haven't noticed (yet) in the tab screen.

@cmonfortep

[cmonfortep]

@oldphones68 @Ammako another question from my side.

The sites that have a wrong favicon, do they show a favicon of a site that is also a bookmark? For example: in the case of @Ammako "github with a reddit favicon", do you have both sites bookmarked?

[cmonfortep]

We have created an internal task to further investigate this issue: https://app.asana.com/0/414730916066338/1200206978219280/f

[Ammako]

I don't have reddit bookmarked, no. Only github. But it must have picked up the favicon from when I was browsing reddit, either way.

Fire button to clear data doesn't fix it. Github is fireproofed, reddit is not.

[cmonfortep]

Thanks so much @Ammako, does GitHub show the wrong favicon in fireproof websites too? I guess the answer is yes, but just to double check with you as we can't reproduce it in our side.

[Ammako]

Reddit data gets cleared due to not being fireproofed, github data stays because it's fireproofed. Reddit favicon stays.

(I'm not entirely sure what you meant, so don't hesitate to elaborate if this doesn't properly answer your question.)

Also, this would probably be a difficult issue to reproduce, because it only happens rarely, and randomly.

Github already had its correct github favicon in bookmarks, at some point in the last few days the favicon was replaced with reddit's favicon.

[cmonfortep]

"Github already had its correct github favicon in bookmarks, at some point in the last few days the favicon was replaced with reddit's favicon." ...huh, interesting...

My question was related to the Fireproof sites list inside settings (settings -> fireproof sites). Inside there, we list all fireproofed sites, I wonder if GitHub shows the wrong favicon on that screen too.

[Ammako]

My question was related to the Fireproof sites list inside settings (settings -> fireproof sites). Inside there, we list all fireproofed sites, I wonder if GitHub shows the wrong favicon on that screen too.

It does!

[oldphones68]

"Github already had its correct github favicon in bookmarks, at some point in the last few days the favicon was replaced with reddit's favicon." ...huh, interesting...

My question was related to the Fireproof sites list inside settings (settings -> fireproof sites). Inside there, we list all fireproofed sites, I wonder if GitHub shows the wrong favicon on that screen too.

For me, not yet noticed. I'll keep watching this. @cmonfortep

[Ammako]

The favicon fixed itself by un-fireproofing github, and after re-fireproofing it remains fixed.

[cmonfortep]

@Ammako thanks for the info.
From what I see, GitHub got the wrong favicon at some point (we need to understand why), and because it was a fireproof website we were just keeping that wrong favicon for the site between sessions.

One question: the problem was fixing but just un-fireproofing the site or did you also clear all data?

Thanks.

[Ammako]

Just by un-fireproofing.

[oldphones68]

@cmonfortep @malmstein I tried to look deeper into this issue. I guess, it happens more after clearing cache fron the system (or phone) manager app.

And, from my experience, if I not make mistake, 'It happens in the morning'!!
Sounds funny, huh!? I also think so.

I can assure that, I have NO automatic cache cleaning app which clear the cache overnight.

By the way, I doubt, whether DDG store the favicons persistently on the device or not?

If DDG needs to connect with a server each and every time it is opened, it may be a fetching issue. But, if the favicons are on _load once, use always_ basis, it should not be like this, should it?

Besides, if DDG requires every time to connect to the server for loading the favicons, I think it can also be treated as a _security_ issue besides being treated as a convenience or performance issue.

Can in any way be related to #527 ? Although, #527 seems to be fixed in #878 ...

[cmonfortep]

@oldphones68 we don't rely on any server for favicons, that logic was changed some time ago. We currently rely on the webview component and the info that component provides to us. Thanks for the info in any case, we will continue investigating this issue.

[oldphones68]

@cmonfortep

we don't rely on any server for favicons, that logic was changed some time ago. We currently rely on the webview component and the info that component provides to us. Thanks for the info in any case, we will continue investigating this issue.

Okey! If that's the situation, then this portion below may help, I hope.

I guess, it happens more after clearing cache fron the system (or phone) manager app.
And, from my experience, if I not make mistake, 'It happens in the morning'!!
Sounds funny, huh!? I also think so.
I can assure that, I have NO automatic cache cleaning app which clear the cache overnight.

[oldphones68]

@malmstein Updated to 5.81.0.

But faced this problem today _morning_

I have no fireproof sites, but this issue happened again.

[malmstein]

@malmstein Updated to 5.81.0.

But faced this problem today _morning_

I have no fireproof sites, but this issue happened again.

@oldphones68 5.81.0 went out before this PR was merged, this fix will be available in the next release. Thanks for letting us know though!