Android: Add account via SSO from 3rd party app results in wrong backstack

Created on 19 Sep 2020  Â·  4Comments  Â·  Source: nextcloud/android

I think we might have an issue with the SSO on the Files app side.

Scenario:

  • Open a 3rd party app
  • use SSO to import an account
  • choose "Add account" instead of an existing

Expected behavior (used to work some versions ago)

  • Files app takes control
  • Access granted at some point
  • Files app shows the files of this new account
  • Pressing back quits the files app and directly returns to the 3rd party app

Actual behavior:

  • Like expected but pressing back goes back to the web ui stuff where the "grant permission" button was, each single step is in the back stack and one has to press back multiple times to return to the 3rd party app.

Sugar-candy solution:

  • Like expected, but when new account request origins from a 3rd party app, directly return to this app after access was granted.

I can confirm this with Notes & Deck and i don't think it's caused by SSO but by the Files app.

approved bug pr exists

All 4 comments

* Like expected, but when new account request origins from a 3rd party app, directly return to this app after access was granted.

I assumed that we do this already… 🙈

assumed that we do this already… 🙈

We never did this 😉. I think you once told me that it is impossible and we therefore always had to press the back button at least one time

ssoLogin

We _never_ did this wink.

Never say never :-D
https://github.com/nextcloud/android/pull/6983

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JSoko picture JSoko  Â·  3Comments

eppfel picture eppfel  Â·  3Comments

JSoko picture JSoko  Â·  3Comments

markbryanduncan picture markbryanduncan  Â·  3Comments

tobiasKaminsky picture tobiasKaminsky  Â·  3Comments