Android: Follow up on "hide on scrolling"

[tobiasKaminsky]

I have tested the PR and have found two issues:

• [x] #6569 The part below the header bar looks strange in dark mode: different grey tone?
• [ ] The FAB button seems to need a long touch time to get hidden/shown. If I scroll fast (and thus touch short to trigger the scrolling), I can trigger a state where the FAB button doesn't get hidden/shown while scrolling.
• [x] The FAB button and the sorting/grid/list action bar are visible in the Text preview screen (and possible others as well)
• [ ] The empty list elements aren't vertically centered anymore (might be to to the parent element PR, can't say for sure).
• [x] header is scrolled down:
  
  
  
  • open app
  
  
  • scroll down, and up so header is gone
  
  
  • go into subfolder / detail view
  
  
  • header is gone (as this state is remembered)
  
  

_Originally posted by @szaimen in https://github.com/nextcloud/android/pull/6262#issuecomment-648956174_

Screenshots

[AndyScherzinger]

@tobiasKaminsky I added further issues I found to the list

[tobiasKaminsky]

The FAB button seems to need a long touch time to get hidden/shown. If I scroll fast (and thus touch short to trigger the scrolling), I can trigger a state where the FAB button doesn't get hidden/shown while scrolling.

Is this still valid?

[szaimen]

The FAB button seems to need a long touch time to get hidden/shown. If I scroll fast (and thus touch short to trigger the scrolling), I can trigger a state where the FAB button doesn't get hidden/shown while scrolling.

Is this still valid?

On 3.13.0 it is, yes 👍

[tobiasKaminsky]

I cannot reproduce it.
If it is still valid, please re-open with a video.

[szaimen]

Here is a screenrecording:
Screen_Recording_20200924-101039.zip
(You have to touch really short during scrolling to trigger this but it definitely still happens)

[tobiasKaminsky]

For me it is shown once the search bar is open fully.

This was introduced by @JorisBodin https://github.com/nextcloud/android/commit/adecd7b5ae95972a0259eebf665a035a10e48073

Maybe you can help us here? 💙

[JorisBodin]

This is a feature of the google lib. So actually make the effect fail. You can remove the option if it's really problematic :)

[tobiasKaminsky]

can remove the option

You mean removing entire "hide FAB on scrolling"?
I am not keen on doing this…

[tobiasKaminsky]

(You have to touch really short during scrolling to trigger this but it definitely still happens)

Hm. I tried many different devices, but I cannot reproduce it :S
Does this also happen if you have more entries to scroll upwards to?

[szaimen]

I think I've located the problem:
It seems like while scrolling down the FAB only hides after the top-bar is completely hidden.
The other way around: if I scroll up, the FAB gets only visible after the top-bar is fully visible again.
I think synchronizing the animation: for scrolling down: hiding the FAB while the top-bar gets hidden and not after it is completely hidden and for scrolling up: making the FAB visible while the top-bar gets visible and not after it is completely visible would solve this issue.
Do you get what I mean?

[tobiasKaminsky]

@szaimen thanks for the detailed info.

@JorisBodin do you see any chance that we can change this behavior as described?