Android: The left side menu in dark mode has the wrong grey tone

[szaimen]

Steps to reproduce

1. Activate the dark mode
2. Open side menu
3. See wrong grey tone. (It is brighter than all other used grey tones.)

Expected behaviour

• should use the same grey tone like on other places

Actual behaviour

• the grey tone is wrong

Environment data

Android version:
10
Device model:
Samsung Galaxy S10e
Stock or customized system:
Stock
Nextcloud app version:
3.12 RC1
Nextcloud server version:
18.0.4
Reverse proxy:
No

Here a screenshot:

[AndyScherzinger]

Cc @JorisBodin @dan0xii @Shagequi @sirambd

[JorisBodin]

@jancborchardt what color would you like?
I find this color here

[szaimen]

I mean it had the same background color like this before and it looked nicer, imo.

[JorisBodin]

I mean it had the same background color like this before and it looked nicer, imo.

I think it's too dark.
The color must be the same as the appbar. Which is lighter than the background.

[szaimen]

I think it's too dark.
The color must be the same as the appbar. Which is lighter than the background.

The thing is, that it was darker before version 3.12 RC1 if I remember correctly.
Otherwise I would probably not have seen it.

Imo it looks better with a darker grey. Especially because the quota bar on the bottom has a darker background.

Also why are the appbar and the side menu not allowed to have different grey tones to it? I see no problem with that... (the mockup isn't showing the dark mode, afaik)

[AndyScherzinger]

I think it's too dark.

I checked Google GMail/Play/Drive and in Darkmode they all use the background coor of the "main view" for the drawer menu also, so it would need to be dark(er).Other than that they also don't use White for font/icon in the drawer menu but grey-ish

[AndyScherzinger]

[JorisBodin]

@AndyScherzinger Yes but the background is not black. If we have black background, the appbar and drawermenu is grey.

[szaimen]

@AndyScherzinger Yes but the background is not black. If we have black background, the appbar and drawermenu is grey.

But the background color of the Nextcloud app is currently not black but a dark grey...

[Shagequi]

Hey,

I like the issue number, that's almost the number of the beast 😂

About this problem, I'll watch what I can do... but to be very honest, this grey doesn't shock me, and allows to see the difference with the background (in dark mode) where the files are present... so I'd say it's rather a good thing.

But I'm going to present you with samples so we can see which one is more interesting

[tobiasKaminsky]

If you ever change this, please make sure to test it with edge cases…
light yellow
dark purple
black
white

all in normal and dark mode :-)

[szaimen]

@Shagequi I've tested the latest PR #6156 (https://github.com/nextcloud/android/pull/6156#issuecomment-634700026)
It seems like the text in the drawer on dark mode is a bit darker now and I still think that making the background color of the drawer the same like the background color of the main view looks better:
Currently | Proposed
------------ | -------------
|

[Shagequi]

@szaimen

I'm more of an enforcer than a decision-maker, awaiting @jancborchardt for approval.
It would take ... two lines, to apply the change :)

[JorisBodin]

@szaimen The menu must be in a lighter color than the background. Like account dialog.

[szaimen]

@szaimen The menu must be in a lighter color than the background.

@JorisBodin Yes, you already said that. But why?

[JorisBodin]

Do you prefer 1 or 2?
|1|2|
|---|---|
|||

For me, the background is to dark for use it in drawer and dialog

[szaimen]

@JorisBodin Thanks for showing an example.
If possible, I would just change the background color of the drawer but leave the background color of the dialog as it currently is.

[szaimen]

My suggestions is also how it is e.g. implemented by the play store, since google uses different colors for the drawer and the dialog as well:
Drawer (same background color as main background) | Dialog (a brighter grey tone background color)
------------ | -------------
|

[JorisBodin]

Drawer (same background color as main background)

Yes but the background color is lighter than nextcloud

[szaimen]

@JorisBodin it seems that we don't come to an agreement here.
What is @jancborchardt's opinion on that? (making only the drawer the same grey tone like the background color)

[AndyScherzinger]

afaik the decision has been reached to use the toolbar color which reflects the correct elevation.

[stale[bot]]

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

[AndyScherzinger]

fixed as discussed with designers shipping with 3.13